Fix clicks on NTP tiles not contributing to Most Visited tiles

content/browser/frame_host/navigator_impl.cc

Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index c63d436dd916555d18149a188b5df67d3b9ca79c..83ee5e9bcc802598c84a37afb0e1f1b9fd4d28a9 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -720,6 +720,14 @@ void NavigatorImpl::RequestOpenURL(
 
     // Navigations in Web UI pages count as browser-initiated navigations.
     params.is_renderer_initiated = false;
+  } else if (source_site_instance &&
+             source_site_instance->GetSiteURL().spec() ==
+                 "chrome-search://remote-ntp/" &&

[Marc Treib, 2016/06/22 12:36:34]

Oh man, we have too many NTP URLs. I didn't even know about this one. From the
top of my head:
- chrome://newtab (the "initial" newtab URL).
- Unless you're in an incognito or guest profile, it gets rewritten to either
  - chrome-search://local-ntp/local-ntp.html, or
  - something like https://www.google.com/_/chrome/newtab (assuming Google is
the DSE)
- Apparently, at some point that gets rewritten again to this
chrome-search://remote-ntp one.
- chrome-native://newtab (on Android).

There are various "is this an NTP URL" functions around, but I'm not sure any of
them will work at this particular point in time. At the least, we should:
- Use the existing constants (e.g.
https://cs.chromium.org/chromium/src/chrome/common/url_constants.cc?rcl=0&l=742)
instead of hardcoding strings.
- Not compare full URL strings directly, but GURL.host() and GURL.scheme().
- Also handle the local NTP.

+             ui::PageTransitionCoreTypeIs(params.transition,
+                                          ui::PAGE_TRANSITION_LINK)) {
+    // Make any click on the new tab page a AUTO_BOOKMARK, consistently with
+    // native implementations like Android's.
+    params.transition = ui::PAGE_TRANSITION_AUTO_BOOKMARK;
   }
 
   if (delegate_)