Fix clicks on NTP tiles not contributing to Most Visited tiles

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <map>
 #include <set>
 #include <utility>
 #include <vector>
@@ skipping 1136 matching lines @@
       url.SchemeIs(content::kChromeUIScheme) &&
       url.host_piece() != chrome::kChromeUIChromeSigninHost) {
     VLOG(1) << "Blocked navigation to " << url.spec() << " from "
             << chrome::kChromeUIChromeSigninURL;
     return false;
   }
 
   return true;
 }
 
+void ChromeContentBrowserClient::OverrideOpenURLParams(
+    const content::SiteInstance* site_instance,
+    content::OpenURLParams* params) {
+  DCHECK(params);
+  if (site_instance &&
+      site_instance->GetSiteURL().SchemeIs(chrome::kChromeSearchScheme) &&
+      site_instance->GetSiteURL().host() ==
+          chrome::kChromeSearchRemoteNtpHost &&

[Marc Treib, 2016/06/27 13:08:15]

Also for the local NTP please!

[mastiz, 2016/06/27 13:50:53]

Done.

+      ui::PageTransitionCoreTypeIs(params->transition,
+                                   ui::PAGE_TRANSITION_LINK)) {
+    // Make any click on the new tab page a AUTO_BOOKMARK, consistently with
+    // native implementations like Android's.

[Marc Treib, 2016/06/27 13:08:15]

nit: This isn't quite accurate - it'll also make e.g. navigations via the
OneGoogleBar AUTO_BOOKMARK, which isn't consistent with Android because that
just doesn't exist on Android.

[mastiz, 2016/06/27 13:50:53]

Done, PTAL.

+    params->transition = ui::PAGE_TRANSITION_AUTO_BOOKMARK;

[Marc Treib, 2016/06/27 13:08:15]

The old code also set renderer_initiated to false, which probably should be the
case anyway?

Re referrer, I'd either just clear it, or check that it's already empty - WDYT?

[mastiz, 2016/06/27 13:50:53]

Done, went conservative and cleared the field out just in case.

+  }
+}
+
 bool ChromeContentBrowserClient::IsSuitableHost(
     content::RenderProcessHost* process_host,
     const GURL& site_url) {
   Profile* profile =
       Profile::FromBrowserContext(process_host->GetBrowserContext());
   // This may be NULL during tests. In that case, just assume any site can
   // share any host.
   if (!profile)
     return true;
 
@@ skipping 1802 matching lines @@
   if (channel <= kMaxDisableEncryptionChannel) {
     static const char* const kWebRtcDevSwitchNames[] = {
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)