Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2084943003: [Telemetry] Specify metrics explicitly in TBMv1 smoke tests (Closed)

Created:
4 years, 6 months ago by eakuefner
Modified:
4 years, 6 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Specify metrics explicitly in TBMv1 smoke tests This CL changes the metric smoke tests in timeline_based_page_test_unittest to specify the metrics they use explicitly, rather than implicitly. The implicit behavior is deprecated now that it's possible to specify v1 metrics to run alongside v2 metrics. BUG=chromium:621035 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/387907f944c1b30c98e58d43adb2f0d018aac5ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py View 4 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
eakuefner
PTAL
4 years, 6 months ago (2016-06-21 21:36:41 UTC) #2
nednguyen
lgtm
4 years, 6 months ago (2016-06-21 21:38:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084943003/1
4 years, 6 months ago (2016-06-21 22:01:54 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 22:24:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698