Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2084943002: [turbofan] Reuse the operation typer's logic in the typer. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reuse the operation typer's logic in the typer. Committed: https://crrev.com/ef925a2739a78c1c607a18eec345303cf97c6ca9 Cr-Commit-Position: refs/heads/master@{#37166}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Tweak + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -222 lines) Patch
M src/compiler/typer.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 8 chunks +13 lines, -222 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-06-21 13:56:38 UTC) #2
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/2084943002/diff/1/src/compiler/operation-typer.h File src/compiler/operation-typer.h (right): https://codereview.chromium.org/2084943002/diff/1/src/compiler/operation-typer.h#newcode22 src/compiler/operation-typer.h:22: class OperationTyper : public ZoneObject { ...
4 years, 6 months ago (2016-06-22 03:49:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084943002/20001
4 years, 6 months ago (2016-06-22 06:28:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 06:53:30 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 06:55:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef925a2739a78c1c607a18eec345303cf97c6ca9
Cr-Commit-Position: refs/heads/master@{#37166}

Powered by Google App Engine
This is Rietveld 408576698