Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h

Issue 2084933002: Implement wrapper tracing verifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use verifier when dchecks are on Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h
new file mode 100644
index 0000000000000000000000000000000000000000..030105ee0c0d9471ec1ef2e05d27366827721569
--- /dev/null
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h
@@ -0,0 +1,73 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ScriptWrappableVisitorVerifier_h
+#define ScriptWrappableVisitorVerifier_h
+
+#include "bindings/core/v8/ScriptWrappableVisitor.h"
+#include "bindings/core/v8/V8AbstractEventListener.h"
+#include "core/dom/DocumentStyleSheetCollection.h"
+#include "core/dom/ElementRareData.h"
+#include "core/dom/NodeListsNodeData.h"
+#include "core/dom/NodeRareData.h"
+#include "core/dom/StyleEngine.h"
+#include "core/dom/shadow/ElementShadow.h"
+#include "core/html/imports/HTMLImportsController.h"
+
+namespace blink {
+
+class ScriptWrappableVisitorVerifier : public WrapperVisitor {
+public:
+ void dispatchTraceWrappers(const ScriptWrappable* t) const override { t->traceWrappers(this); }
+#define DECLARE_DISPATCH_TRACE_WRAPPERS(className) \
+ void dispatchTraceWrappers(const className* t) const override { t->traceWrappers(this); }
+
+ WRAPPER_VISITOR_SPECIAL_CLASSES(DECLARE_DISPATCH_TRACE_WRAPPERS);
+
+#undef DECLARE_DISPATCH_TRACE_WRAPPERS
+ void dispatchTraceWrappers(const void*) const override {}
+
+ void traceWrappers(const ScopedPersistent<v8::Value>*) const override {}
+ void traceWrappers(const ScopedPersistent<v8::Object>*) const override {}
+ void markWrapper(const v8::PersistentBase<v8::Object>*) const override {}
+
+ void pushToMarkingDeque(
+ void (*traceWrappersCallback)(const WrapperVisitor*, const void*),
+ HeapObjectHeader* (*heapObjectHeaderCallback)(const void*),
+ const void* object) const override
+ {
+ if (!heapObjectHeaderCallback(object)->isWrapperHeaderMarked()) {
+ /*
+ * If this branch is hit, it means that a white (not discovered by
+ * traceWrappers) object was assigned as a member to a black object
+ * (already processed by traceWrappers). Black object will not be
+ * processed anymore so White object will remain undetected and
+ * therefore its wrapper and all wrappers reachable from it would be
+ * collected.
+ *
+ * Most often this means there is a write barrier missing somewhere.
+ * Check backtrace to see which classes are causing this and review
+ * all the places where white class is set to the black class.
+ */
+ NOTREACHED();
+ }
+ traceWrappersCallback(this, object);
+ }
+
+ bool markWrapperHeader(HeapObjectHeader* header) const override
+ {
+ if (!m_visitedHeaders.contains(header)) {
+ m_visitedHeaders.add(header);
+ return true;
+ }
+ return false;
+ }
+ void markWrappersInAllWorlds(const ScriptWrappable*) const override {}
+ void markWrappersInAllWorlds(const void*) const override {}
+private:
+ mutable WTF::HashSet<HeapObjectHeader*> m_visitedHeaders;
+};
+
+}
+#endif

Powered by Google App Engine
This is Rietveld 408576698