Remove {,un}setPendingActivity from AudioContext.

Remove {,un}setPendingActivity from AudioContext.

This CL removes use of {,un}setPendingActivity from AudioContext. They were used to make the wrappers alive until Document is destroyed. This CL replaces the hack with a |hasPendingActivity()| impl.

Also, this removes ASSERT(m_isStopScheduled) from d-tor. This is never set when OfflineAudioContext::create() fails after creating an instance.

TEST=media/
BUG=354845
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170015

[kouhei (in TOK), 2014-03-21 16:32:15]

Would you take a look?

[kouhei (in TOK), 2014-03-21 16:32:40]

https://codereview.chromium.org/208493002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/208493002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioContext.cpp:276: return
executionContext()->activeDOMObjectsAreStopped();
Sorry this must be the opposite!

[haraken, 2014-03-21 16:42:20]

This CL will slightly change the timing when hasPendingActivity() returns true.
Before this CL, we were unsetting pending activity in AudioContext::clear(),
which was called in the main thread a bit later than AudioContext::stop(). After
this CL, we will unset pending activity in AudioContext::stop(). However, I
don't think this difference matters. LGTM.

https://codereview.chromium.org/208493002/diff/10001/Source/modules/webaudio/...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/208493002/diff/10001/Source/modules/webaudio/...
Source/modules/webaudio/AudioContext.cpp:275: // According to spec AudioContext
must die only after page navigate.

navigate => navigates or navigation

[kouhei (in TOK), 2014-03-21 16:44:09]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-21 16:44:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/208493002/30001

[kouhei (in TOK), 2014-03-21 16:44:47]

Thanks for review!

https://codereview.chromium.org/208493002/diff/10001/Source/modules/webaudio/...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/208493002/diff/10001/Source/modules/webaudio/...
Source/modules/webaudio/AudioContext.cpp:275: // According to spec AudioContext
must die only after page navigate.
On 2014/03/21 16:42:20, haraken wrote:
> 
> navigate => navigates or navigation

Done.

[commit-bot: I haz the power, 2014-03-21 17:17:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-21 17:17:43]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[kouhei (in TOK), 2014-03-26 01:21:33]

PTAL.

https://codereview.chromium.org/208493002/diff/50001/Source/modules/webaudio/...
File Source/modules/webaudio/AudioContext.cpp (left):

https://codereview.chromium.org/208493002/diff/50001/Source/modules/webaudio/...
Source/modules/webaudio/AudioContext.cpp:174: ASSERT(m_isStopScheduled);
m_isStopScheduled is not set when OfflineAudioContext::create fails after
creating instance.

[kouhei (in TOK), 2014-03-26 01:21:57]

sorry. looks like still having rare crashes. please wait.

[kouhei (in TOK), 2014-03-26 03:01:10]

trybots passing. PTAL.

[haraken, 2014-03-26 03:40:06]

LGTM

[kouhei (in TOK), 2014-03-26 04:33:32]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-26 04:33:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/208493002/90001

[commit-bot: I haz the power, 2014-03-26 04:54:49]

Change committed as 170015