Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: src/code-stubs.cc

Issue 2084913006: [ic] Let LoadGlobalIC load the variable name from TypeFeedbackMetadata. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@fix-load-ic-slow-stub
Patch Set: Addressing comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 Node* context = assembler->Parameter(4); 441 Node* context = assembler->Parameter(4);
442 442
443 CodeStubAssembler::LoadICParameters p(context, receiver, name, slot, vector); 443 CodeStubAssembler::LoadICParameters p(context, receiver, name, slot, vector);
444 assembler->LoadIC(&p); 444 assembler->LoadIC(&p);
445 } 445 }
446 446
447 void LoadGlobalICTrampolineStub::GenerateAssembly( 447 void LoadGlobalICTrampolineStub::GenerateAssembly(
448 CodeStubAssembler* assembler) const { 448 CodeStubAssembler* assembler) const {
449 typedef compiler::Node Node; 449 typedef compiler::Node Node;
450 450
451 Node* name = assembler->Parameter(0); 451 Node* slot = assembler->Parameter(0);
452 Node* slot = assembler->Parameter(1); 452 Node* context = assembler->Parameter(1);
453 Node* context = assembler->Parameter(2);
454 Node* vector = assembler->LoadTypeFeedbackVectorForStub(); 453 Node* vector = assembler->LoadTypeFeedbackVectorForStub();
455 454
456 CodeStubAssembler::LoadICParameters p(context, nullptr, name, slot, vector); 455 CodeStubAssembler::LoadICParameters p(context, nullptr, nullptr, slot,
456 vector);
457 assembler->LoadGlobalIC(&p); 457 assembler->LoadGlobalIC(&p);
458 } 458 }
459 459
460 void LoadGlobalICStub::GenerateAssembly(CodeStubAssembler* assembler) const { 460 void LoadGlobalICStub::GenerateAssembly(CodeStubAssembler* assembler) const {
461 typedef compiler::Node Node; 461 typedef compiler::Node Node;
462 462
463 Node* name = assembler->Parameter(0); 463 Node* slot = assembler->Parameter(0);
464 Node* slot = assembler->Parameter(1); 464 Node* vector = assembler->Parameter(1);
465 Node* vector = assembler->Parameter(2); 465 Node* context = assembler->Parameter(2);
466 Node* context = assembler->Parameter(3);
467 466
468 CodeStubAssembler::LoadICParameters p(context, nullptr, name, slot, vector); 467 CodeStubAssembler::LoadICParameters p(context, nullptr, nullptr, slot,
468 vector);
469 assembler->LoadGlobalIC(&p); 469 assembler->LoadGlobalIC(&p);
470 } 470 }
471 471
472 void AllocateHeapNumberStub::GenerateAssembly( 472 void AllocateHeapNumberStub::GenerateAssembly(
473 CodeStubAssembler* assembler) const { 473 CodeStubAssembler* assembler) const {
474 typedef compiler::Node Node; 474 typedef compiler::Node Node;
475 475
476 Node* result = assembler->AllocateHeapNumber(); 476 Node* result = assembler->AllocateHeapNumber();
477 assembler->Return(result); 477 assembler->Return(result);
478 } 478 }
(...skipping 4251 matching lines...) Expand 10 before | Expand all | Expand 10 after
4730 if (type->Is(Type::UntaggedPointer())) { 4730 if (type->Is(Type::UntaggedPointer())) {
4731 return Representation::External(); 4731 return Representation::External();
4732 } 4732 }
4733 4733
4734 DCHECK(!type->Is(Type::Untagged())); 4734 DCHECK(!type->Is(Type::Untagged()));
4735 return Representation::Tagged(); 4735 return Representation::Tagged();
4736 } 4736 }
4737 4737
4738 } // namespace internal 4738 } // namespace internal
4739 } // namespace v8 4739 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698