Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/browsing_data/browsing_data_counter_utils.h

Issue 2084903002: Moved BrowsingDataCounter and part of BrowsingDataCounterUtils to components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed deps Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_counter_utils.h
diff --git a/chrome/browser/browsing_data/browsing_data_counter_utils.h b/chrome/browser/browsing_data/browsing_data_counter_utils.h
index d71d24b30e1323767b02ad1356d078dfca5b7998..0148333f5559827ecce343e977bbc859a754a182 100644
--- a/chrome/browser/browsing_data/browsing_data_counter_utils.h
+++ b/chrome/browser/browsing_data/browsing_data_counter_utils.h
@@ -6,7 +6,9 @@
#define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_COUNTER_UTILS_H_
#include "base/strings/string16.h"
-#include "chrome/browser/browsing_data/browsing_data_counter.h"
+#include "chrome/browser/profiles/profile.h"
+#include "components/browsing_data/browsing_data_utils.h"
+#include "components/browsing_data/counters/browsing_data_counter.h"
// Whether the browsing data counters experiment is enabled.
bool AreCountersEnabled();
@@ -15,22 +17,6 @@ bool AreCountersEnabled();
base::string16 GetCounterTextFromResult(
const BrowsingDataCounter::Result* result);
-// Browsing data types as seen in the Android UI.
-// TODO(msramek): Reuse this enum as the canonical representation of the
-// user-facing browsing data types in the Desktop UI as well.
-//
-// A Java counterpart will be generated for this enum.
-// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser
-enum BrowsingDataType {
- HISTORY,
- CACHE,
- COOKIES,
- PASSWORDS,
- FORM_DATA,
- BOOKMARKS,
- NUM_TYPES
-};
-
// Copies the name of the deletion preference corresponding to the given
// |data_type| to |out_pref|. Returns false if no such preference exists.
bool GetDeletionPreferenceFromDataType(
@@ -38,6 +24,7 @@ bool GetDeletionPreferenceFromDataType(
// Creates a new instance of BrowsingDataCounter that is counting the data
// related to a given deletion preference |pref_name|.
-BrowsingDataCounter* CreateCounterForPreference(std::string pref_name);
+BrowsingDataCounter* CreateCounterForPreference(std::string pref_name,
+ Profile* profile);
#endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_COUNTER_UTILS_H_

Powered by Google App Engine
This is Rietveld 408576698