Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 2084903002: Moved BrowsingDataCounter and part of BrowsingDataCounterUtils to components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed round 2 of comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc ('K') | « chrome/browser/browsing_data/browsing_data_remover_browsertest.cc ('k') | chrome/browser/browsing_data/cache_counter.h » ('j') | chrome/browser/browsing_data/passwords_counter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
index 5c02dcb9dd46d2b4b8c2a55ded720ff975bc1472..2d1bd53bb2650151e306483ae3582fc19b870fe2 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
@@ -52,6 +52,7 @@
#include "components/autofill/core/common/autofill_constants.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
+#include "components/browsing_data/browsing_data_utils.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/content_settings/core/common/content_settings.h"
#include "components/content_settings/core/common/content_settings_pattern.h"
@@ -1035,7 +1036,7 @@ class BrowsingDataRemoverTest : public testing::Test {
TestingBrowserProcess::GetGlobal()->SetLocalState(nullptr);
}
- void BlockUntilBrowsingDataRemoved(BrowsingDataRemover::TimePeriod period,
+ void BlockUntilBrowsingDataRemoved(browsing_data::TimePeriod period,
int remove_mask,
bool include_protected_origins) {
BrowsingDataRemover* remover =
@@ -1061,7 +1062,7 @@ class BrowsingDataRemoverTest : public testing::Test {
}
void BlockUntilOriginDataRemoved(
- BrowsingDataRemover::TimePeriod period,
+ browsing_data::TimePeriod period,
int remove_mask,
const BrowsingDataFilterBuilder& filter_builder) {
BrowsingDataRemover* remover =
@@ -1171,9 +1172,8 @@ class BrowsingDataRemoverTest : public testing::Test {
// Tests ---------------------------------------------------------------------
TEST_F(BrowsingDataRemoverTest, RemoveCookieForever) {
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_COOKIES,
- false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_COOKIES, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_COOKIES, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1188,9 +1188,8 @@ TEST_F(BrowsingDataRemoverTest, RemoveCookieForever) {
}
TEST_F(BrowsingDataRemoverTest, RemoveCookieLastHour) {
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::LAST_HOUR,
- BrowsingDataRemover::REMOVE_COOKIES,
- false);
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_HOUR,
+ BrowsingDataRemover::REMOVE_COOKIES, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_COOKIES, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1211,7 +1210,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveCookiesDomainBlacklist) {
RegistrableDomainFilterBuilder::BLACKLIST);
filter.AddRegisterableDomain(kTestRegisterableDomain1);
filter.AddRegisterableDomain(kTestRegisterableDomain3);
- BlockUntilOriginDataRemoved(BrowsingDataRemover::LAST_HOUR,
+ BlockUntilOriginDataRemoved(browsing_data::LAST_HOUR,
BrowsingDataRemover::REMOVE_COOKIES, filter);
EXPECT_EQ(BrowsingDataRemover::REMOVE_COOKIES, GetRemovalMask());
@@ -1246,8 +1245,8 @@ TEST_F(BrowsingDataRemoverTest, RemoveSafeBrowsingCookieForever) {
tester.AddCookie();
ASSERT_TRUE(tester.ContainsCookie());
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_COOKIES, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_COOKIES, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_COOKIES, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1260,8 +1259,8 @@ TEST_F(BrowsingDataRemoverTest, RemoveSafeBrowsingCookieLastHour) {
tester.AddCookie();
ASSERT_TRUE(tester.ContainsCookie());
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::LAST_HOUR,
- BrowsingDataRemover::REMOVE_COOKIES, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_HOUR,
+ BrowsingDataRemover::REMOVE_COOKIES, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_COOKIES, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1278,7 +1277,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveSafeBrowsingCookieForeverWithPredicate) {
RegistrableDomainFilterBuilder filter(
RegistrableDomainFilterBuilder::BLACKLIST);
filter.AddRegisterableDomain(kTestRegisterableDomain1);
- BlockUntilOriginDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilOriginDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_COOKIES, filter);
EXPECT_EQ(BrowsingDataRemover::REMOVE_COOKIES, GetRemovalMask());
@@ -1288,7 +1287,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveSafeBrowsingCookieForeverWithPredicate) {
RegistrableDomainFilterBuilder filter2(
RegistrableDomainFilterBuilder::WHITELIST);
filter2.AddRegisterableDomain(kTestRegisterableDomain1);
- BlockUntilOriginDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilOriginDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_COOKIES, filter2);
EXPECT_FALSE(tester.ContainsCookie());
}
@@ -1300,8 +1299,8 @@ TEST_F(BrowsingDataRemoverTest, RemoveChannelIDForever) {
EXPECT_EQ(0, tester.ssl_config_changed_count());
EXPECT_EQ(1, tester.ChannelIDCount());
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_CHANNEL_IDS, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_CHANNEL_IDS, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_CHANNEL_IDS, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1319,8 +1318,8 @@ TEST_F(BrowsingDataRemoverTest, RemoveChannelIDLastHour) {
EXPECT_EQ(0, tester.ssl_config_changed_count());
EXPECT_EQ(2, tester.ChannelIDCount());
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::LAST_HOUR,
- BrowsingDataRemover::REMOVE_CHANNEL_IDS, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_HOUR,
+ BrowsingDataRemover::REMOVE_CHANNEL_IDS, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_CHANNEL_IDS, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1343,8 +1342,9 @@ TEST_F(BrowsingDataRemoverTest, RemoveChannelIDsForServerIdentifiers) {
RegistrableDomainFilterBuilder::WHITELIST);
filter_builder.AddRegisterableDomain(kTestRegisterableDomain1);
- BlockUntilOriginDataRemoved(BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_CHANNEL_IDS, filter_builder);
+ BlockUntilOriginDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_CHANNEL_IDS,
+ filter_builder);
EXPECT_EQ(1, tester.ChannelIDCount());
net::ChannelIDStore::ChannelIDList channel_ids;
@@ -1359,7 +1359,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveUnprotectedLocalStorageForever) {
policy->AddProtected(kOrigin1.GetOrigin());
#endif
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_LOCAL_STORAGE,
false);
@@ -1389,7 +1389,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveProtectedLocalStorageForever) {
policy->AddProtected(kOrigin1.GetOrigin());
#endif
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_LOCAL_STORAGE,
true);
@@ -1418,7 +1418,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveLocalStorageForLastWeek) {
CreateMockPolicy();
#endif
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::LAST_WEEK,
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_WEEK,
BrowsingDataRemover::REMOVE_LOCAL_STORAGE,
false);
@@ -1448,8 +1448,8 @@ TEST_F(BrowsingDataRemoverTest, RemoveHistoryForever) {
tester.AddHistory(kOrigin1, base::Time::Now());
ASSERT_TRUE(tester.HistoryContainsURL(kOrigin1));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_HISTORY, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_HISTORY, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1467,8 +1467,8 @@ TEST_F(BrowsingDataRemoverTest, RemoveHistoryForLastHour) {
ASSERT_TRUE(tester.HistoryContainsURL(kOrigin1));
ASSERT_TRUE(tester.HistoryContainsURL(kOrigin2));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::LAST_HOUR,
- BrowsingDataRemover::REMOVE_HISTORY, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_HOUR,
+ BrowsingDataRemover::REMOVE_HISTORY, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1492,8 +1492,8 @@ TEST_F(BrowsingDataRemoverTest, RemoveHistoryProhibited) {
ASSERT_TRUE(tester.HistoryContainsURL(kOrigin1));
ASSERT_TRUE(tester.HistoryContainsURL(kOrigin2));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::LAST_HOUR,
- BrowsingDataRemover::REMOVE_HISTORY, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_HOUR,
+ BrowsingDataRemover::REMOVE_HISTORY, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1513,8 +1513,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveMultipleTypes) {
int removal_mask = BrowsingDataRemover::REMOVE_HISTORY |
BrowsingDataRemover::REMOVE_COOKIES;
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
- removal_mask, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING, removal_mask, false);
EXPECT_EQ(removal_mask, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1545,8 +1544,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveMultipleTypesHistoryProhibited) {
int removal_mask = BrowsingDataRemover::REMOVE_HISTORY |
BrowsingDataRemover::REMOVE_COOKIES;
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::LAST_HOUR,
- removal_mask, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_HOUR, removal_mask, false);
EXPECT_EQ(removal_mask, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -1573,7 +1571,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveFaviconsForever) {
favicon_tester.VisitAndAddFavicon(page_url);
ASSERT_TRUE(favicon_tester.HasFaviconForPageURL(page_url));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_HISTORY, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY, GetRemovalMask());
EXPECT_FALSE(favicon_tester.HasFaviconForPageURL(page_url));
@@ -1600,7 +1598,7 @@ TEST_F(BrowsingDataRemoverTest, ExpireBookmarkFavicons) {
favicon_tester.VisitAndAddFavicon(bookmarked_page);
ASSERT_TRUE(favicon_tester.HasFaviconForPageURL(bookmarked_page));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_HISTORY, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY, GetRemovalMask());
EXPECT_TRUE(favicon_tester.HasExpiredFaviconForPageURL(bookmarked_page));
@@ -1608,7 +1606,7 @@ TEST_F(BrowsingDataRemoverTest, ExpireBookmarkFavicons) {
TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForeverBoth) {
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
+ browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_FILE_SYSTEMS |
BrowsingDataRemover::REMOVE_WEBSQL |
BrowsingDataRemover::REMOVE_APPCACHE |
@@ -1645,7 +1643,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForeverOnlyTemporary) {
#endif
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
+ browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_FILE_SYSTEMS |
BrowsingDataRemover::REMOVE_WEBSQL |
BrowsingDataRemover::REMOVE_APPCACHE |
@@ -1689,7 +1687,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForeverOnlyPersistent) {
#endif
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
+ browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_FILE_SYSTEMS |
BrowsingDataRemover::REMOVE_WEBSQL |
BrowsingDataRemover::REMOVE_APPCACHE |
@@ -1733,7 +1731,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForeverNeither) {
#endif
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
+ browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_FILE_SYSTEMS |
BrowsingDataRemover::REMOVE_WEBSQL |
BrowsingDataRemover::REMOVE_APPCACHE |
@@ -1776,7 +1774,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForeverSpecificOrigin) {
RegistrableDomainFilterBuilder::WHITELIST);
builder.AddRegisterableDomain(kTestRegisterableDomain1);
// Remove Origin 1.
- BlockUntilOriginDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilOriginDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_APPCACHE |
BrowsingDataRemover::REMOVE_SERVICE_WORKERS |
BrowsingDataRemover::REMOVE_CACHE_STORAGE |
@@ -1814,7 +1812,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForeverSpecificOrigin) {
TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForLastHour) {
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::LAST_HOUR,
+ browsing_data::LAST_HOUR,
BrowsingDataRemover::REMOVE_FILE_SYSTEMS |
BrowsingDataRemover::REMOVE_WEBSQL |
BrowsingDataRemover::REMOVE_APPCACHE |
@@ -1854,7 +1852,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForLastHour) {
TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedDataForLastWeek) {
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::LAST_WEEK,
+ browsing_data::LAST_WEEK,
BrowsingDataRemover::REMOVE_FILE_SYSTEMS |
BrowsingDataRemover::REMOVE_WEBSQL |
BrowsingDataRemover::REMOVE_APPCACHE |
@@ -1900,7 +1898,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedUnprotectedOrigins) {
#endif
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
+ browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_FILE_SYSTEMS |
BrowsingDataRemover::REMOVE_WEBSQL |
BrowsingDataRemover::REMOVE_APPCACHE |
@@ -1950,7 +1948,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedProtectedSpecificOrigin) {
builder.AddRegisterableDomain(kTestRegisterableDomain1);
// Try to remove kOrigin1. Expect failure.
- BlockUntilOriginDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilOriginDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_APPCACHE |
BrowsingDataRemover::REMOVE_SERVICE_WORKERS |
BrowsingDataRemover::REMOVE_CACHE_STORAGE |
@@ -1999,7 +1997,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedProtectedOrigins) {
// Try to remove kOrigin1. Expect success.
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
+ browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_APPCACHE |
BrowsingDataRemover::REMOVE_SERVICE_WORKERS |
BrowsingDataRemover::REMOVE_CACHE_STORAGE |
@@ -2044,7 +2042,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveQuotaManagedIgnoreExtensionsAndDevTools) {
#endif
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
+ browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_APPCACHE |
BrowsingDataRemover::REMOVE_SERVICE_WORKERS |
BrowsingDataRemover::REMOVE_CACHE_STORAGE |
@@ -2094,7 +2092,7 @@ TEST_F(BrowsingDataRemoverTest, TimeBasedHistoryRemoval) {
RegistrableDomainFilterBuilder builder(
RegistrableDomainFilterBuilder::BLACKLIST);
- BlockUntilOriginDataRemoved(BrowsingDataRemover::LAST_HOUR,
+ BlockUntilOriginDataRemoved(browsing_data::LAST_HOUR,
BrowsingDataRemover::REMOVE_HISTORY, builder);
EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY, GetRemovalMask());
@@ -2112,9 +2110,8 @@ TEST_F(BrowsingDataRemoverTest, AutofillRemovalLastHour) {
tester.AddProfilesAndCards();
ASSERT_TRUE(tester.HasProfile());
- BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::LAST_HOUR,
- BrowsingDataRemover::REMOVE_FORM_DATA, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_HOUR,
+ BrowsingDataRemover::REMOVE_FORM_DATA, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_FORM_DATA, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -2129,9 +2126,8 @@ TEST_F(BrowsingDataRemoverTest, AutofillRemovalEverything) {
tester.AddProfilesAndCards();
ASSERT_TRUE(tester.HasProfile());
- BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_FORM_DATA, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_FORM_DATA, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_FORM_DATA, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -2148,9 +2144,8 @@ TEST_F(BrowsingDataRemoverTest, AutofillOriginsRemovedWithHistory) {
EXPECT_TRUE(tester.HasOrigin(kWebOrigin));
EXPECT_TRUE(tester.HasOrigin(autofill::kSettingsOrigin));
- BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::LAST_HOUR,
- BrowsingDataRemover::REMOVE_HISTORY, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::LAST_HOUR,
+ BrowsingDataRemover::REMOVE_HISTORY, false);
EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY, GetRemovalMask());
EXPECT_EQ(BrowsingDataHelper::UNPROTECTED_WEB, GetOriginTypeMask());
@@ -2224,9 +2219,8 @@ TEST_F(BrowsingDataRemoverTest, ZeroSuggestCacheClear) {
PrefService* prefs = GetProfile()->GetPrefs();
prefs->SetString(omnibox::kZeroSuggestCachedResults,
"[\"\", [\"foo\", \"bar\"]]");
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_COOKIES,
- false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_COOKIES, false);
// Expect the prefs to be cleared when cookies are removed.
EXPECT_TRUE(prefs->GetString(omnibox::kZeroSuggestCachedResults).empty());
@@ -2256,9 +2250,9 @@ TEST_F(BrowsingDataRemoverTest, ContentProtectionPlatformKeysRemoval) {
EXPECT_CALL(*cryptohome_client, TpmAttestationDeleteKeys(_, _, _, _))
.WillOnce(WithArgs<3>(Invoke(FakeDBusCall)));
- BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_CONTENT_LICENSES, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_CONTENT_LICENSES,
+ false);
chromeos::DBusThreadManager::Shutdown();
}
@@ -2275,9 +2269,8 @@ TEST_F(BrowsingDataRemoverTest, DomainReliability_Beacons) {
const ClearDomainReliabilityTester& tester =
clear_domain_reliability_tester();
- BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_HISTORY, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_HISTORY, false);
EXPECT_EQ(1u, tester.clear_count());
EXPECT_EQ(CLEAR_BEACONS, tester.last_clear_mode());
}
@@ -2286,9 +2279,8 @@ TEST_F(BrowsingDataRemoverTest, DomainReliability_Contexts) {
const ClearDomainReliabilityTester& tester =
clear_domain_reliability_tester();
- BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_COOKIES, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_COOKIES, false);
EXPECT_EQ(1u, tester.clear_count());
EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode());
}
@@ -2298,9 +2290,9 @@ TEST_F(BrowsingDataRemoverTest, DomainReliability_ContextsWin) {
clear_domain_reliability_tester();
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_HISTORY |
- BrowsingDataRemover::REMOVE_COOKIES, false);
+ browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_HISTORY | BrowsingDataRemover::REMOVE_COOKIES,
+ false);
EXPECT_EQ(1u, tester.clear_count());
EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode());
}
@@ -2309,9 +2301,8 @@ TEST_F(BrowsingDataRemoverTest, DomainReliability_ProtectedOrigins) {
const ClearDomainReliabilityTester& tester =
clear_domain_reliability_tester();
- BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_COOKIES, true);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_COOKIES, true);
EXPECT_EQ(1u, tester.clear_count());
EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode());
}
@@ -2322,9 +2313,9 @@ TEST_F(BrowsingDataRemoverTest, DomainReliability_ProtectedOrigins) {
// monitor case again.
TEST_F(BrowsingDataRemoverTest, DISABLED_DomainReliability_NoMonitor) {
BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_HISTORY |
- BrowsingDataRemover::REMOVE_COOKIES, false);
+ browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_HISTORY | BrowsingDataRemover::REMOVE_COOKIES,
+ false);
}
TEST_F(BrowsingDataRemoverTest, RemoveDownloadsByTimeOnly) {
@@ -2336,7 +2327,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveDownloadsByTimeOnly) {
*tester.download_manager(),
RemoveDownloadsByURLAndTime(ProbablySameFilter(filter), _, _));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_DOWNLOADS, false);
}
@@ -2351,7 +2342,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveDownloadsByOrigin) {
*tester.download_manager(),
RemoveDownloadsByURLAndTime(ProbablySameFilter(filter), _, _));
- BlockUntilOriginDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilOriginDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_DOWNLOADS, builder);
}
@@ -2360,9 +2351,8 @@ TEST_F(BrowsingDataRemoverTest, RemovePasswordStatistics) {
EXPECT_CALL(*tester.store(), RemoveStatisticsCreatedBetweenImpl(
base::Time(), base::Time::Max()));
- BlockUntilBrowsingDataRemoved(
- BrowsingDataRemover::EVERYTHING,
- BrowsingDataRemover::REMOVE_HISTORY, false);
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
+ BrowsingDataRemover::REMOVE_HISTORY, false);
}
TEST_F(BrowsingDataRemoverTest, RemovePasswordsByTimeOnly) {
@@ -2373,7 +2363,7 @@ TEST_F(BrowsingDataRemoverTest, RemovePasswordsByTimeOnly) {
EXPECT_CALL(*tester.store(),
RemoveLoginsByURLAndTimeImpl(ProbablySameFilter(filter), _, _))
.WillOnce(Return(password_manager::PasswordStoreChangeList()));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_PASSWORDS, false);
}
@@ -2387,7 +2377,7 @@ TEST_F(BrowsingDataRemoverTest, RemovePasswordsByOrigin) {
EXPECT_CALL(*tester.store(),
RemoveLoginsByURLAndTimeImpl(ProbablySameFilter(filter), _, _))
.WillOnce(Return(password_manager::PasswordStoreChangeList()));
- BlockUntilOriginDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilOriginDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_PASSWORDS, builder);
}
@@ -2397,7 +2387,7 @@ TEST_F(BrowsingDataRemoverTest, DisableAutoSignIn) {
EXPECT_CALL(*tester.store(), DisableAutoSignInForAllLoginsImpl())
.WillOnce(Return(password_manager::PasswordStoreChangeList()));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_COOKIES, false);
}
@@ -2409,7 +2399,7 @@ TEST_F(BrowsingDataRemoverTest, DisableAutoSignInAfterRemovingPasswords) {
EXPECT_CALL(*tester.store(), DisableAutoSignInForAllLoginsImpl())
.WillOnce(Return(password_manager::PasswordStoreChangeList()));
- BlockUntilBrowsingDataRemoved(BrowsingDataRemover::EVERYTHING,
+ BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,
BrowsingDataRemover::REMOVE_COOKIES |
BrowsingDataRemover::REMOVE_PASSWORDS,
false);
@@ -2437,7 +2427,7 @@ TEST_F(BrowsingDataRemoverTest, RemoveContentSettingsWithBlacklist) {
RegistrableDomainFilterBuilder::BLACKLIST);
filter.AddRegisterableDomain(kTestRegisterableDomain1);
filter.AddRegisterableDomain(kTestRegisterableDomain3);
- BlockUntilOriginDataRemoved(BrowsingDataRemover::LAST_HOUR,
+ BlockUntilOriginDataRemoved(browsing_data::LAST_HOUR,
BrowsingDataRemover::REMOVE_SITE_USAGE_DATA,
filter);
« chrome/browser/browsing_data/browsing_data_counter_utils_unittest.cc ('K') | « chrome/browser/browsing_data/browsing_data_remover_browsertest.cc ('k') | chrome/browser/browsing_data/cache_counter.h » ('j') | chrome/browser/browsing_data/passwords_counter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698