chrome/browser/resources/md_history/list_container.html - Issue 2084843002: [MD History] Add history-list-container between app and history lists.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_history/list_container.html

Issue 2084843002: [MD History] Add history-list-container between app and history lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tim_toolbar

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_history/app.js ('K') | « chrome/browser/resources/md_history/compiled_resources2.gyp ('k') | chrome/browser/resources/md_history/list_container.js » ('j') | chrome/browser/resources/md_history/list_container.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-pages/iron-pages.h tml">

	3 <link rel="import" href="chrome://history/grouped_list.html">

	4 <link rel="import" href="chrome://history/history_list.html">

	5

	6 <dom-module id="history-list-container">

	7 <template>

	8 <style>

	9 :host {

	10 display: block;

	11 height: 100%;

	12 overflow: hidden;

	13 }

	14

	15 #main-container,
	tsergeant 2016/06/23 06:35:25 #main-container doesn't exist here. #main-container doesn't exist here. calamity 2016/06/24 05:39:47 Removed. Show quoted text On 2016/06/23 06:35:25, tsergeant wrote: > #main-container doesn't exist here. Removed.
	16 #content,

	17 #content > * {

	18 height: 100%;

	19 }

	20 </style>

	21 <iron-pages id="content" attr-for-selected="id"

	22 selected="[[selectedPage_]]">

	23 <history-list id="history-list" querying="[[queryState.querying]]"
	tsergeant 2016/06/23 06:35:25 Here's a yak to shave while you're here: How abou Here's a yak to shave while you're here: How about changing the IDs to #infinite-list and #grouped-list? I've never been a particular fan of element-name-as-ID. calamity 2016/06/24 05:39:47 Shaved. Show quoted text On 2016/06/23 06:35:25, tsergeant wrote: > Here's a yak to shave while you're here: > > How about changing the IDs to #infinite-list and #grouped-list? I've never been > a particular fan of element-name-as-ID. Shaved.
	24 searched-term="[[queryResult_.info.term]]"></history-list>

	25 <template is="dom-if" if="[[grouped]]">

	26 <history-grouped-list id="history-grouped-list"

	27 range="[[queryState.range]]"

	28 query-start-time="[[queryResult_.info.queryStartTime]]"

	29 query-end-time="[[queryResult_.info.queryEndTime]]"

	30 searched-term="[[queryResult_.info.term]]">

	31 </history-grouped-list>

	32 </template>

	33 </template>

	34 </iron-pages>

	35 </template>

	36 <script src="chrome://history/list_container.js"></script>

	37 </dom-module>

OLD	NEW