Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2084813002: PDF: Small cleanup of Polymer usage (Closed)

Created:
4 years, 6 months ago by tsergeant
Modified:
4 years, 6 months ago
Reviewers:
raymes
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, darin-cc_chromium.org, jam, arv+watch_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Small cleanup of Polymer usage * Replace direct imports of polymer.html with chrome://resources/html/polymer.html. This means the manual import of polymer_config.js is no longer necessary. * Avoid importing deprecated iron-flex-layout files by changing paper-styles import. BUG=621736 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777 Cr-Commit-Position: refs/heads/master@{#401161}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Reorder imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-bookmarks-content/viewer-bookmarks-content.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/index.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
tsergeant
PTAL!
4 years, 6 months ago (2016-06-21 01:51:50 UTC) #3
raymes
Thanks Tim lgtm with one question/request https://codereview.chromium.org/2084813002/diff/1/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html File chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html (right): https://codereview.chromium.org/2084813002/diff/1/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html#newcode4 chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html:4: <link rel="import" href="chrome://resources/cr_elements/icons.html"> ...
4 years, 6 months ago (2016-06-22 00:07:59 UTC) #4
tsergeant
https://codereview.chromium.org/2084813002/diff/1/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html File chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html (right): https://codereview.chromium.org/2084813002/diff/1/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html#newcode4 chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html:4: <link rel="import" href="chrome://resources/cr_elements/icons.html"> On 2016/06/22 00:07:58, raymes wrote: > ...
4 years, 6 months ago (2016-06-22 00:32:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084813002/20001
4 years, 6 months ago (2016-06-22 00:33:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 02:05:22 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 02:06:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0402963c3f9452446b89d3d7807bcf749a519777
Cr-Commit-Position: refs/heads/master@{#401161}

Powered by Google App Engine
This is Rietveld 408576698