Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2084793002: Subzero: Catch addition patterns for Index in Address Optimizer (Closed)

Created:
4 years, 6 months ago by manasijm
Modified:
4 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Catch addition patterns for Index in Address Optimization Index is Index=Var+Const ==> set Index=Var, Offset+=(Const<<Shift) Index is Index=Const+Var ==> set Index=Var, Offset+=(Const<<Shift) Index is Index=Var-Const ==> set Index=Var, Offset-=(Const<<Shift) BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2e4b960b20e6ed2ad9453657fe8d34d0e7fd933c

Patch Set 1 #

Patch Set 2 : Update test, verify if makes sense #

Patch Set 3 : Fix overflow check #

Patch Set 4 : Revert test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -33 lines) Patch
M src/IceTargetLoweringX86BaseImpl.h View 1 2 6 chunks +37 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
manasijm
4 years, 6 months ago (2016-06-21 01:07:00 UTC) #2
Jim Stichnoth
lgtm
4 years, 6 months ago (2016-06-21 21:16:43 UTC) #3
manasijm
4 years, 6 months ago (2016-06-21 21:22:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
2e4b960b20e6ed2ad9453657fe8d34d0e7fd933c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698