net/quic/crypto/proof_verifier_chromium_test.cc - Issue 2084783002: Cleanup HPKP error handling and weak DH key handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/proof_verifier_chromium_test.cc

Issue 2084783002: Cleanup HPKP error handling and weak DH key handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@require_ct_enforcer

Patch Set: Fix bad test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/crypto/proof_verifier_chromium_test.cc

diff --git a/net/quic/crypto/proof_verifier_chromium_test.cc b/net/quic/crypto/proof_verifier_chromium_test.cc

index 733e781952d1d82143570ee58d54d003b44e776a..c467e99bcbc7dcb86a894ba51fedeefc0b406488 100644

--- a/net/quic/crypto/proof_verifier_chromium_test.cc

+++ b/net/quic/crypto/proof_verifier_chromium_test.cc

@@ -430,7 +430,8 @@ TEST_F(ProofVerifierChromiumTest, PKPEnforced) {

ASSERT_TRUE(details_.get());

ProofVerifyDetailsChromium* verify_details =

static_cast<ProofVerifyDetailsChromium*>(details_.get());

- EXPECT_EQ(0u, verify_details->cert_verify_result.cert_status);

+ EXPECT_TRUE(verify_details->cert_verify_result.cert_status &

+ CERT_STATUS_PINNED_KEY_MISSING);

EXPECT_FALSE(verify_details->pkp_bypassed);

EXPECT_NE("", verify_details->pinning_failure_log);

}

« no previous file with comments | « net/quic/crypto/proof_verifier_chromium.cc ('k') | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »