components/ssl_errors/error_info.cc - Issue 2084783002: Cleanup HPKP error handling and weak DH key handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ssl_errors/error_info.cc

Issue 2084783002: Cleanup HPKP error handling and weak DH key handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@require_ct_enforcer

Patch Set: Fix bad test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ssl_errors/error_info.cc

diff --git a/components/ssl_errors/error_info.cc b/components/ssl_errors/error_info.cc

index 06dc3cbe86ffb7afd2e583640291a6ce141e9b33..310abccf4a1fe79b9cbfe3d46b2290bf94982506 100644

--- a/components/ssl_errors/error_info.cc

+++ b/components/ssl_errors/error_info.cc

@@ -131,12 +131,6 @@ ErrorInfo ErrorInfo::CreateError(ErrorType error_type,

short_description =

l10n_util::GetStringUTF16(IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION);

break;

- case CERT_WEAK_KEY_DH:

- details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_WEAK_KEY_DETAILS,

- UTF8ToUTF16(request_url.host()));

- short_description =

- l10n_util::GetStringUTF16(IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION);

- break;

case CERT_NAME_CONSTRAINT_VIOLATION:

details = l10n_util::GetStringFUTF16(

IDS_CERT_ERROR_NAME_CONSTRAINT_VIOLATION_DETAILS,

@@ -203,8 +197,6 @@ ErrorInfo::ErrorType ErrorInfo::NetErrorToErrorType(int net_error) {

return CERT_NAME_CONSTRAINT_VIOLATION;

case net::ERR_CERT_VALIDITY_TOO_LONG:

return CERT_VALIDITY_TOO_LONG;

- case net::ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY:

- return CERT_WEAK_KEY_DH;

case net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN:

return CERT_PINNED_KEY_MISSING;

default:

« no previous file with comments | « components/ssl_errors/error_info.h ('k') | net/http/transport_security_state.h » ('j') | no next file with comments »