Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 208473004: rebaseline_server: fix --editable mode (Closed)

Created:
6 years, 9 months ago by epoger
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: fix --editable mode complete revert of https://skia.googlesource.com/skia/+/736be3527214ddbd3dd7e42a89a374c62d98f370 partial revert of https://skia.googlesource.com/skia/+/579942387bed9259b03419c593503022e1399931 and glue made necessary by the above. (SkipBuildbotRuns) BUG=skia:2319 NOTREECHECKS=True NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -59 lines) Patch
M gm/rebaseline_server/server.py View 9 chunks +71 lines, -57 lines 0 comments Download
M gm/rebaseline_server/static/index.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Ready for review at patchset 1.
6 years, 9 months ago (2014-03-21 16:51:34 UTC) #1
Stephen White
I must admit I am becoming even less familiar with this code that I was ...
6 years, 9 months ago (2014-03-21 16:58:04 UTC) #2
epoger
On 2014/03/21 16:58:04, Stephen White wrote: > I must admit I am becoming even less ...
6 years, 9 months ago (2014-03-21 17:29:59 UTC) #3
epoger
The CQ bit was checked by epoger@google.com
6 years, 9 months ago (2014-03-21 17:30:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/208473004/1
6 years, 9 months ago (2014-03-21 17:30:07 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 17:30:14 UTC) #6
Message was sent while issue was closed.
Change committed as 13893

Powered by Google App Engine
This is Rietveld 408576698