Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2084723003: [iOS] Fix initialisation of net::URLRequestContext. (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org, Eugene But (OOO till 7-30), Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Fix initialisation of net::URLRequestContext. After https://codereview.chromium.org/2067843003, the factory method net::URLRequestContextBuilder::SetHttpNetworkSessionComponents checks that ct_policy_enforcer and cert_transparency_verifier are set but did not fix all code path on iOS (as some of them are only excercised by downstream tests). So this CL move the ownership of net::CTPolicyVerifier to the globals variable of IOSChromeIOThread (instead of leaking it) and correctly pass this to the net::URLRequestContext created. BUG=620179 Committed: https://crrev.com/5e6deacd502aea944eaaa37ad51936ad877462af Cr-Commit-Position: refs/heads/master@{#400957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 6 months ago (2016-06-21 09:52:19 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years, 6 months ago (2016-06-21 10:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084723003/1
4 years, 6 months ago (2016-06-21 11:17:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 11:53:53 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 11:55:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e6deacd502aea944eaaa37ad51936ad877462af
Cr-Commit-Position: refs/heads/master@{#400957}

Powered by Google App Engine
This is Rietveld 408576698