Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2084703005: Fix bug with illegal spread as single arrow parameter (Closed)

Created:
4 years, 6 months ago by nickie
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
caitp (gmail), v8-reviews_googlegroups.com, vogelheim
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bug with illegal spread as single arrow parameter R=adamk@chromium.org BUG=chromium:621496 LOG=N Committed: https://crrev.com/b9f682baafb8fee8cca154d6dd66359facc06a69 Cr-Commit-Position: refs/heads/master@{#37196}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/parsing/parser-base.h View 1 chunk +5 lines, -2 lines 1 comment Download
A test/mjsunit/harmony/regress/regress-crbug-621496.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
nickie
4 years, 6 months ago (2016-06-22 09:25:26 UTC) #1
nickie
https://codereview.chromium.org/2084703005/diff/1/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/2084703005/diff/1/src/parsing/parser-base.h#newcode1599 src/parsing/parser-base.h:1599: ExpressionClassifier::AllProductions); This is now identical to the code handling ...
4 years, 6 months ago (2016-06-22 09:35:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084703005/1
4 years, 6 months ago (2016-06-22 14:27:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 14:55:10 UTC) #6
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-22 15:24:06 UTC) #8
adamk
lgtm, thx for the quick fix
4 years, 6 months ago (2016-06-22 17:43:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084703005/1
4 years, 6 months ago (2016-06-22 18:02:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 18:05:16 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 18:07:59 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b9f682baafb8fee8cca154d6dd66359facc06a69
Cr-Commit-Position: refs/heads/master@{#37196}

Powered by Google App Engine
This is Rietveld 408576698