WIP: prototype ffi support

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 
 #include "src/assert-scope.h"
@@ skipping 4852 matching lines @@
 #define NON_IC_KIND_LIST(V) \
   V(FUNCTION)               \
   V(OPTIMIZED_FUNCTION)     \
   V(BYTECODE_HANDLER)       \
   V(STUB)                   \
   V(HANDLER)                \
   V(BUILTIN)                \
   V(REGEXP)                 \
   V(WASM_FUNCTION)          \
   V(WASM_TO_JS_FUNCTION)    \
-  V(JS_TO_WASM_FUNCTION)
+  V(JS_TO_WASM_FUNCTION)    \
+  V(JS_TO_NATIVE_FUNCTION)

[Benedikt Meurer, 2016/06/21 03:26:01]

Not sure this necessary. Those functions could also use the BUILTIN kind,
similar to what we do for TurboFan builtins, i.e. MathSin and friends.

[ofrobots, 2016/06/23 01:02:51]

I think the same argument could be made for JS_TO_WASM_FUNCTION.

These functions would have 1:1 mapping to user provided function pointers. Also,
note this code in log.cc:

    case AbstractCode::BUILTIN:
      description =
          isolate_->builtins()->name(code_object->GetCode()->builtin_index());
      tag = CodeEventListener::BUILTIN_TAG;
      break;

I think all JS_TO_NATIVE_FUNCTIONs should have be considered unique (i.e.
shouldn't share a builtin_index). Are you proposing adding builtin indices for
each of these wrapper functions?

[Benedikt Meurer, 2016/06/23 03:34:07]

JS_TO_WASM is somewhat special and likely subject to change in some way.
But I you are right, I forgot about the implication of BUILTIN for logging. So,
yes, JS_TO_NATIVE_FUNCTION sounds good to me.

 
 #define IC_KIND_LIST(V) \
   V(LOAD_IC)            \
   V(LOAD_GLOBAL_IC)     \
   V(KEYED_LOAD_IC)      \
   V(CALL_IC)            \
   V(STORE_IC)           \
   V(KEYED_STORE_IC)     \
   V(BINARY_OP_IC)       \
   V(COMPARE_IC)         \
@@ skipping 5922 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_