Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2084643003: Invalidate FFmpegDemuxer WeakPtrs on the right thread. (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate FFmpegDemuxer WeakPtrs on the right thread. Previously these may not have been invalidated until the class is destructed on the render thread, when they are bound to the media thread. BUG=618625 TEST=none Committed: https://crrev.com/9053fbc0d49919dd9e48b86d7df820562e845d80 Cr-Commit-Position: refs/heads/master@{#400835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M media/filters/ffmpeg_demuxer.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
DaleCurtis
4 years, 6 months ago (2016-06-20 17:53:35 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 6 months ago (2016-06-20 19:00:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084643003/1
4 years, 6 months ago (2016-06-20 19:53:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241863)
4 years, 6 months ago (2016-06-20 20:55:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084643003/1
4 years, 6 months ago (2016-06-20 22:23:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 23:40:42 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 23:44:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9053fbc0d49919dd9e48b86d7df820562e845d80
Cr-Commit-Position: refs/heads/master@{#400835}

Powered by Google App Engine
This is Rietveld 408576698