test/unittests/interpreter/bytecode-array-iterator-unittest.cc - Issue 2084623002: Reland: [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

Issue 2084623002: Reland: [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Reland Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/Generators.golden ('k') | test/unittests/interpreter/interpreter-assembler-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-iterator-unittest.cc b/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

index 9e2ea863bcbc1d01f1757e4c38989632a6e0b45c..f24c818c3b51eb839a60d1288931aba3d4242cae 100644

--- a/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

@@ -229,8 +229,7 @@ TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) {

CHECK_EQ(iterator.current_bytecode(), Bytecode::kCallRuntime);

CHECK_EQ(iterator.current_offset(), offset);

CHECK_EQ(iterator.current_operand_scale(), OperandScale::kSingle);

- CHECK_EQ(static_cast<Runtime::FunctionId>(iterator.GetRuntimeIdOperand(0)),

- Runtime::kLoadIC_Miss);

+ CHECK_EQ(iterator.GetRuntimeIdOperand(0), Runtime::kLoadIC_Miss);

CHECK_EQ(iterator.GetRegisterOperand(1).index(), reg_0.index());

CHECK_EQ(iterator.GetRegisterCountOperand(2), 1);

CHECK(!iterator.done());