Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2084623002: Reland: [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode. (Closed)

Created:
4 years, 6 months ago by rmcilroy
Modified:
4 years, 6 months ago
Reviewers:
epertoso, oth
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode. Make intrinsic ids a contiguous set of ids so that the switch statement can build a table switch rather than doing a large if/else tree. BUG=v8:4822 LOG=N Committed: https://crrev.com/36abd28a8d9932eb55d7c2bf3ad5e7cfe3eb99ea Committed: https://crrev.com/6003ed04890cac8bcfe7b4adb9b33f819fa508d4 Cr-Original-Commit-Position: refs/heads/master@{#37135} Cr-Commit-Position: refs/heads/master@{#37145}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : Fix Windows #

Patch Set 4 : Reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -95 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 2 3 3 chunks +3 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 3 2 chunks +11 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 1 2 chunks +15 lines, -2 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 2 3 chunks +12 lines, -2 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 3 chunks +32 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode-expectations-printer.cc View 1 3 chunks +10 lines, -9 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 28 chunks +52 lines, -52 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 2 3 7 chunks +13 lines, -13 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084623002/20001
4 years, 6 months ago (2016-06-20 16:14:34 UTC) #2
rmcilroy
Orion, PTAL at the interpreter changes. Enrico, PTAL at the compiler changes. This doesn't seem ...
4 years, 6 months ago (2016-06-20 16:18:00 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/9111)
4 years, 6 months ago (2016-06-20 16:18:25 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084623002/40001
4 years, 6 months ago (2016-06-20 16:20:24 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 16:42:41 UTC) #10
oth
Sweet, lgtm.
4 years, 6 months ago (2016-06-21 08:44:15 UTC) #11
epertoso
lgtm
4 years, 6 months ago (2016-06-21 09:05:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084623002/40001
4 years, 6 months ago (2016-06-21 10:52:20 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-21 10:54:25 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/36abd28a8d9932eb55d7c2bf3ad5e7cfe3eb99ea Cr-Commit-Position: refs/heads/master@{#37135}
4 years, 6 months ago (2016-06-21 10:55:20 UTC) #17
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2085823003/ by machenbach@chromium.org. ...
4 years, 6 months ago (2016-06-21 11:51:55 UTC) #18
Michael Achenbach
The revert didn't help. But I might have found the real culprit. Will reland in ...
4 years, 6 months ago (2016-06-21 12:49:33 UTC) #19
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2086853002/ by machenbach@chromium.org. ...
4 years, 6 months ago (2016-06-21 13:26:35 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084623002/60001
4 years, 6 months ago (2016-06-21 14:08:20 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-21 14:37:27 UTC) #26
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 14:40:07 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6003ed04890cac8bcfe7b4adb9b33f819fa508d4
Cr-Commit-Position: refs/heads/master@{#37145}

Powered by Google App Engine
This is Rietveld 408576698