Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2084603003: Change func(void) to func() (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Change func(void) to func() Since PDFium is compiled as C++ code, the void keyword is not needed. BUG=pdfium:519 Committed: https://pdfium.googlesource.com/pdfium/+/bff506d3b5e03891c137d9fe18f65cae112ebf2a

Patch Set 1 #

Patch Set 2 : style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M core/fpdfapi/fpdf_font/ttgsubtable.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/ttgsubtable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxcrt/include/fx_system.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_gdipext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/Field.h View 1 chunk +1 line, -1 line 0 comments Download
M fxjse/context.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 11 chunks +14 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_resolveprocessor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Wei Li
pls review, thanks
4 years, 6 months ago (2016-06-20 18:15:39 UTC) #2
dsinclair
lgtm
4 years, 6 months ago (2016-06-20 18:19:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084603003/20001
4 years, 6 months ago (2016-06-20 18:20:02 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 18:37:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/bff506d3b5e03891c137d9fe18f65cae112e...

Powered by Google App Engine
This is Rietveld 408576698