Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: mojo/edk/system/local_message_pipe_endpoint.cc

Issue 2084593005: Rationalize AddAwakable...() and RemoveAwakable...() methods. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/local_message_pipe_endpoint.h ('k') | mojo/edk/system/message_pipe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/local_message_pipe_endpoint.cc
diff --git a/mojo/edk/system/local_message_pipe_endpoint.cc b/mojo/edk/system/local_message_pipe_endpoint.cc
index 5d728422bad47157d7fa2cc4486b94bc7f8d3d60..af5915593807ba3195b266a71fd7f2f2d14d9058 100644
--- a/mojo/edk/system/local_message_pipe_endpoint.cc
+++ b/mojo/edk/system/local_message_pipe_endpoint.cc
@@ -150,9 +150,9 @@ HandleSignalsState LocalMessagePipeEndpoint::GetHandleSignalsState() const {
MojoResult LocalMessagePipeEndpoint::AddAwakable(
Awakable* awakable,
- MojoHandleSignals signals,
- bool force,
uint64_t context,
+ bool force,
+ MojoHandleSignals signals,
HandleSignalsState* signals_state) {
DCHECK(is_open_);
@@ -161,31 +161,26 @@ MojoResult LocalMessagePipeEndpoint::AddAwakable(
*signals_state = state;
if (state.satisfies(signals)) {
if (force)
- awakable_list_.Add(awakable, signals, context);
+ awakable_list_.Add(awakable, context, signals);
return MOJO_RESULT_ALREADY_EXISTS;
}
- if (!state.can_satisfy(signals))
+ if (!state.can_satisfy(signals)) {
+ if (force)
+ awakable_list_.Add(awakable, context, signals);
return MOJO_RESULT_FAILED_PRECONDITION;
+ }
- awakable_list_.Add(awakable, signals, context);
+ awakable_list_.Add(awakable, context, signals);
return MOJO_RESULT_OK;
}
void LocalMessagePipeEndpoint::RemoveAwakable(
- Awakable* awakable,
- HandleSignalsState* signals_state) {
- DCHECK(is_open_);
- awakable_list_.Remove(awakable);
- if (signals_state)
- *signals_state = GetHandleSignalsState();
-}
-
-void LocalMessagePipeEndpoint::RemoveAwakableWithContext(
+ bool match_context,
Awakable* awakable,
uint64_t context,
HandleSignalsState* signals_state) {
DCHECK(is_open_);
- awakable_list_.RemoveWithContext(awakable, context);
+ awakable_list_.Remove(match_context, awakable, context);
if (signals_state)
*signals_state = GetHandleSignalsState();
}
« no previous file with comments | « mojo/edk/system/local_message_pipe_endpoint.h ('k') | mojo/edk/system/message_pipe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698