Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: mojo/edk/system/data_pipe_consumer_dispatcher.cc

Issue 2084593005: Rationalize AddAwakable...() and RemoveAwakable...() methods. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/data_pipe_consumer_dispatcher.h ('k') | mojo/edk/system/data_pipe_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/data_pipe_consumer_dispatcher.cc
diff --git a/mojo/edk/system/data_pipe_consumer_dispatcher.cc b/mojo/edk/system/data_pipe_consumer_dispatcher.cc
index eb93a0452bbd0e89d654e6e5ad29842125954c74..e7bf2f6d4fa3aa55f0ca490cffd0bb0c657cd2d7 100644
--- a/mojo/edk/system/data_pipe_consumer_dispatcher.cc
+++ b/mojo/edk/system/data_pipe_consumer_dispatcher.cc
@@ -194,29 +194,23 @@ HandleSignalsState DataPipeConsumerDispatcher::GetHandleSignalsStateImplNoLock()
MojoResult DataPipeConsumerDispatcher::AddAwakableImplNoLock(
Awakable* awakable,
- MojoHandleSignals signals,
- bool force,
uint64_t context,
+ bool force,
+ MojoHandleSignals signals,
HandleSignalsState* signals_state) {
mutex().AssertHeld();
- return data_pipe_->ConsumerAddAwakable(awakable, signals, force, context,
+ return data_pipe_->ConsumerAddAwakable(awakable, context, force, signals,
signals_state);
}
void DataPipeConsumerDispatcher::RemoveAwakableImplNoLock(
- Awakable* awakable,
- HandleSignalsState* signals_state) {
- mutex().AssertHeld();
- data_pipe_->ConsumerRemoveAwakable(awakable, signals_state);
-}
-
-void DataPipeConsumerDispatcher::RemoveAwakableWithContextImplNoLock(
+ bool match_context,
Awakable* awakable,
uint64_t context,
HandleSignalsState* signals_state) {
mutex().AssertHeld();
- data_pipe_->ConsumerRemoveAwakableWithContext(awakable, context,
- signals_state);
+ data_pipe_->ConsumerRemoveAwakable(match_context, awakable, context,
+ signals_state);
}
void DataPipeConsumerDispatcher::StartSerializeImplNoLock(
« no previous file with comments | « mojo/edk/system/data_pipe_consumer_dispatcher.h ('k') | mojo/edk/system/data_pipe_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698