Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: mojo/edk/system/data_pipe.h

Issue 2084593005: Rationalize AddAwakable...() and RemoveAwakable...() methods. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/core_test_base.cc ('k') | mojo/edk/system/data_pipe.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/data_pipe.h
diff --git a/mojo/edk/system/data_pipe.h b/mojo/edk/system/data_pipe.h
index 5afa4567309b8b7143d4f4d4f4b5a96b437cb3fb..78fa471df67e4634d9775a885666b44faeb2e8f1 100644
--- a/mojo/edk/system/data_pipe.h
+++ b/mojo/edk/system/data_pipe.h
@@ -115,15 +115,14 @@ class DataPipe final : public ChannelEndpointClient {
MojoResult ProducerEndWriteData(uint32_t num_bytes_written);
HandleSignalsState ProducerGetHandleSignalsState();
MojoResult ProducerAddAwakable(Awakable* awakable,
- MojoHandleSignals signals,
- bool force,
uint64_t context,
+ bool force,
+ MojoHandleSignals signals,
HandleSignalsState* signals_state);
- void ProducerRemoveAwakable(Awakable* awakable,
+ void ProducerRemoveAwakable(bool match_context,
+ Awakable* awakable,
+ uint64_t context,
HandleSignalsState* signals_state);
- void ProducerRemoveAwakableWithContext(Awakable* awakable,
- uint64_t context,
- HandleSignalsState* signals_state);
void ProducerStartSerialize(Channel* channel,
size_t* max_size,
size_t* max_platform_handles);
@@ -153,15 +152,14 @@ class DataPipe final : public ChannelEndpointClient {
MojoResult ConsumerEndReadData(uint32_t num_bytes_read);
HandleSignalsState ConsumerGetHandleSignalsState();
MojoResult ConsumerAddAwakable(Awakable* awakable,
- MojoHandleSignals signals,
- bool force,
uint64_t context,
+ bool force,
+ MojoHandleSignals signals,
HandleSignalsState* signals_state);
- void ConsumerRemoveAwakable(Awakable* awakable,
+ void ConsumerRemoveAwakable(bool match_context,
+ Awakable* awakable,
+ uint64_t context,
HandleSignalsState* signals_state);
- void ConsumerRemoveAwakableWithContext(Awakable* awakable,
- uint64_t context,
- HandleSignalsState* signals_state);
void ConsumerStartSerialize(Channel* channel,
size_t* max_size,
size_t* max_platform_handles);
« no previous file with comments | « mojo/edk/system/core_test_base.cc ('k') | mojo/edk/system/data_pipe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698