Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1583)

Side by Side Diff: mojo/edk/system/simple_dispatcher.h

Issue 2084593005: Rationalize AddAwakable...() and RemoveAwakable...() methods. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/system/remote_message_pipe_unittest.cc ('k') | mojo/edk/system/simple_dispatcher.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_ 5 #ifndef MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_
6 #define MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_ 6 #define MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_
7 7
8 #include <list> 8 #include <list>
9 9
10 #include "mojo/edk/system/awakable_list.h" 10 #include "mojo/edk/system/awakable_list.h"
(...skipping 15 matching lines...) Expand all
26 ~SimpleDispatcher() override; 26 ~SimpleDispatcher() override;
27 27
28 // To be called by subclasses when the state changes. 28 // To be called by subclasses when the state changes.
29 void OnHandleSignalsStateChangeNoLock(const HandleSignalsState& old_state, 29 void OnHandleSignalsStateChangeNoLock(const HandleSignalsState& old_state,
30 const HandleSignalsState& new_state) 30 const HandleSignalsState& new_state)
31 MOJO_EXCLUSIVE_LOCKS_REQUIRED(mutex()); 31 MOJO_EXCLUSIVE_LOCKS_REQUIRED(mutex());
32 32
33 // |Dispatcher| protected methods: 33 // |Dispatcher| protected methods:
34 void CancelAllStateNoLock() override; 34 void CancelAllStateNoLock() override;
35 MojoResult AddAwakableImplNoLock(Awakable* awakable, 35 MojoResult AddAwakableImplNoLock(Awakable* awakable,
36 uint64_t context,
37 bool force,
36 MojoHandleSignals signals, 38 MojoHandleSignals signals,
37 bool force,
38 uint64_t context,
39 HandleSignalsState* signals_state) override; 39 HandleSignalsState* signals_state) override;
40 void RemoveAwakableImplNoLock(Awakable* awakable, 40 void RemoveAwakableImplNoLock(bool match_context,
41 Awakable* awakable,
42 uint64_t context,
41 HandleSignalsState* signals_state) override; 43 HandleSignalsState* signals_state) override;
42 void RemoveAwakableWithContextImplNoLock(
43 Awakable* awakable,
44 uint64_t context,
45 HandleSignalsState* signals_state) override;
46 44
47 private: 45 private:
48 AwakableList awakable_list_ MOJO_GUARDED_BY(mutex()); 46 AwakableList awakable_list_ MOJO_GUARDED_BY(mutex());
49 47
50 MOJO_DISALLOW_COPY_AND_ASSIGN(SimpleDispatcher); 48 MOJO_DISALLOW_COPY_AND_ASSIGN(SimpleDispatcher);
51 }; 49 };
52 50
53 } // namespace system 51 } // namespace system
54 } // namespace mojo 52 } // namespace mojo
55 53
56 #endif // MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_ 54 #endif // MOJO_EDK_SYSTEM_SIMPLE_DISPATCHER_H_
OLDNEW
« no previous file with comments | « mojo/edk/system/remote_message_pipe_unittest.cc ('k') | mojo/edk/system/simple_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698