Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2084583004: Fix tab coloring bugs with multiple open profiles which used different colors. (Closed)

Created:
4 years, 6 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tab coloring bugs with multiple open profiles which used different colors. Instead of caching based on incognito state, cache based on the actual colors used. This also fixes what I think was a real bug with not paying attention to a changing stroke color. BUG=616403 TEST=Install theme from bug comment 0, hit ctrl-T several times, open a window from a second, unthemed profile, hit ctrl-T more times, and verify the tab background color in the second wnidow is the default one and not the themed one. Committed: https://crrev.com/85c0fcf270d8f28720054c636748ad506e3a4078 Cr-Commit-Position: refs/heads/master@{#401109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M chrome/browser/ui/views/tabs/tab.cc View 4 chunks +30 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Kasting
4 years, 6 months ago (2016-06-21 02:00:58 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-06-21 15:51:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084583004/1
4 years, 6 months ago (2016-06-21 21:07:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 21:17:51 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 21:19:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85c0fcf270d8f28720054c636748ad506e3a4078
Cr-Commit-Position: refs/heads/master@{#401109}

Powered by Google App Engine
This is Rietveld 408576698