Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2084553006: Fix the UK keyboard overlay Enter key shape (Closed)

Created:
4 years, 6 months ago by afakhry
Modified:
4 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the UK keyboard overlay Enter key shape Screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LYkFTQnkwSW5nbVU/view?usp=sharing Screenshot: https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_Ld0g4RVJiZ2RyUlU/view?usp=sharing BUG=150632 TEST=manually CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/35ae457252520cf4a8002868ff441b524394b065 Cr-Commit-Position: refs/heads/master@{#401266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -18 lines) Patch
M chrome/browser/resources/chromeos/keyboard_overlay.css View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay.js View 5 chunks +65 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
afakhry
Xiyuan, please review. Thank you!
4 years, 6 months ago (2016-06-21 22:41:23 UTC) #3
xiyuan
lgtm
4 years, 6 months ago (2016-06-21 23:12:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084553006/1
4 years, 6 months ago (2016-06-22 12:59:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 13:10:57 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 13:12:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35ae457252520cf4a8002868ff441b524394b065
Cr-Commit-Position: refs/heads/master@{#401266}

Powered by Google App Engine
This is Rietveld 408576698