Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2084553003: Better command line error messages (Closed)

Created:
4 years, 6 months ago by hausner
Modified:
4 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M runtime/bin/main.cc View 1 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hausner
4 years, 6 months ago (2016-06-20 21:41:28 UTC) #3
regis
LGTM https://codereview.chromium.org/2084553003/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/2084553003/diff/1/runtime/bin/main.cc#newcode219 runtime/bin/main.cc:219: CommandLineOptions* vm_options) { This is the opportunity to ...
4 years, 6 months ago (2016-06-20 21:53:12 UTC) #4
hausner
https://codereview.chromium.org/2084553003/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/2084553003/diff/1/runtime/bin/main.cc#newcode219 runtime/bin/main.cc:219: CommandLineOptions* vm_options) { On 2016/06/20 21:53:12, regis wrote: > ...
4 years, 6 months ago (2016-06-20 22:37:05 UTC) #5
hausner
4 years, 6 months ago (2016-06-20 22:42:00 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a71a6fc689ccb00db05210fd46718899b7f0d197 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698