mash: Migrate tray audio and deps to common.

mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
TBR=reveman@chromium.org,yusukes@chromium.org,sky@chromium.org

Committed: https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72
Cr-Commit-Position: refs/heads/master@{#401470}

[msw, 2016-06-22 20:45:43]

Description was changed from

==========
mash: Migrate tray audio and deps to common.

BUG=619636
==========

to

==========
mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
==========

[msw, 2016-06-22 20:45:43]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-06-22 20:49:38]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-06-22 20:50:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084533008/20001

[msw, 2016-06-22 20:50:50]

The CQ bit was unchecked by msw@chromium.org

[commit-bot: I haz the power, 2016-06-22 20:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 20:50:53]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[msw, 2016-06-22 20:51:09]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2016-06-22 20:52:00]

Hey James, please take a look; thanks!

[commit-bot: I haz the power, 2016-06-22 20:52:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084533008/20001

[commit-bot: I haz the power, 2016-06-22 21:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 21:16:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-06-22 21:27:24]

LGTM. It might be worth pinging oshima about where DisplayInfo should end up.

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
File ash/common/display/display_info.h (right):

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
ash/common/display/display_info.h:5: #ifndef ASH_COMMON_DISPLAY_DISPLAY_INFO_H_
Can you file a bug about migrating / refactoring DisplayManager? We're going to
be a in weird state where some of //ash/display lives in //ash/common, I suspect
for a long time.

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
ash/common/display/display_info.h:6: #define ASH_COMMON_DISPLAY_DISPLAY_INFO_H_
Also, do you think it would make more sense to move DisplayInfo to //ui/display?
It has no //ash dependencies. I vaguely remember oshima talking about moving the
display code around, but I'm not sure in which direction.

https://codereview.chromium.org/2084533008/diff/20001/ash/common/system/audio...
File ash/common/system/audio/volume_view.cc (right):

https://codereview.chromium.org/2084533008/diff/20001/ash/common/system/audio...
ash/common/system/audio/volume_view.cc:258:
ash::UMA_STATUS_AREA_CHANGED_VOLUME_MENU :
nit: Can you take these out of namespace ash:: while you're here?

https://codereview.chromium.org/2084533008/diff/20001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2084533008/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:82: // TODO(msw): Remove this when DisplayManager has been
moved.
maybe cite the bug here?

[msw, 2016-06-22 21:33:31]

msw@chromium.org changed reviewers:
+ oshima@chromium.org

[msw, 2016-06-22 21:33:33]

Hey Oshima, WDYT about moving display_info to ui?

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
File ash/common/display/display_info.h (right):

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
ash/common/display/display_info.h:6: #define ASH_COMMON_DISPLAY_DISPLAY_INFO_H_
On 2016/06/22 21:27:23, James Cook wrote:
> Also, do you think it would make more sense to move DisplayInfo to
//ui/display?
> It has no //ash dependencies. I vaguely remember oshima talking about moving
the
> display code around, but I'm not sure in which direction.

I think that makes sense; +oshima for any thoughts.

[oshima, 2016-06-22 21:39:24]

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
File ash/common/display/display_info.h (right):

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
ash/common/display/display_info.h:6: #define ASH_COMMON_DISPLAY_DISPLAY_INFO_H_
On 2016/06/22 21:33:32, msw wrote:
> On 2016/06/22 21:27:23, James Cook wrote:
> > Also, do you think it would make more sense to move DisplayInfo to
> //ui/display?
> > It has no //ash dependencies. I vaguely remember oshima talking about moving
> the
> > display code around, but I'm not sure in which direction.
> 
> I think that makes sense; +oshima for any thoughts.

Yes, that (and moving a few other display classes) is the plan, so you can move
it now.

[oshima, 2016-06-22 21:53:16]

On 2016/06/22 21:39:24, oshima wrote:
>
https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
> File ash/common/display/display_info.h (right):
> 
>
https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
> ash/common/display/display_info.h:6: #define
ASH_COMMON_DISPLAY_DISPLAY_INFO_H_
> On 2016/06/22 21:33:32, msw wrote:
> > On 2016/06/22 21:27:23, James Cook wrote:
> > > Also, do you think it would make more sense to move DisplayInfo to
> > //ui/display?
> > > It has no //ash dependencies. I vaguely remember oshima talking about
moving
> > the
> > > display code around, but I'm not sure in which direction.
> > 
> > I think that makes sense; +oshima for any thoughts.
> 
> Yes, that (and moving a few other display classes) is the plan, so you can
move
> it now.

Forgot to mention. Please move to ui/display/manager

[msw, 2016-06-22 22:16:11]

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
File ash/common/display/display_info.h (right):

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
ash/common/display/display_info.h:5: #ifndef ASH_COMMON_DISPLAY_DISPLAY_INFO_H_
On 2016/06/22 21:27:23, James Cook wrote:
> Can you file a bug about migrating / refactoring DisplayManager? We're going
to
> be a in weird state where some of //ash/display lives in //ash/common, I
suspect
> for a long time.

Done. http://crbug.com/622480

https://codereview.chromium.org/2084533008/diff/20001/ash/common/display/disp...
ash/common/display/display_info.h:6: #define ASH_COMMON_DISPLAY_DISPLAY_INFO_H_
On 2016/06/22 21:39:23, oshima wrote:
> On 2016/06/22 21:33:32, msw wrote:
> > On 2016/06/22 21:27:23, James Cook wrote:
> > > Also, do you think it would make more sense to move DisplayInfo to
> > //ui/display?
> > > It has no //ash dependencies. I vaguely remember oshima talking about
moving
> > the
> > > display code around, but I'm not sure in which direction.
> > 
> > I think that makes sense; +oshima for any thoughts.
> 
> Yes, that (and moving a few other display classes) is the plan, so you can
move
> it now.

Hmm, there's already a ui::DisplayMode class that would conflict with moving the
below ash::DisplayMode struct to the ui:: namespace. Using the display::
namespace wouldn't conflict, but the two objects should really be combined; and
either action is outside the scope of this CL. I'll stick with the new
ash/common/display location for now.

https://codereview.chromium.org/2084533008/diff/20001/ash/common/system/audio...
File ash/common/system/audio/volume_view.cc (right):

https://codereview.chromium.org/2084533008/diff/20001/ash/common/system/audio...
ash/common/system/audio/volume_view.cc:258:
ash::UMA_STATUS_AREA_CHANGED_VOLUME_MENU :
On 2016/06/22 21:27:24, James Cook wrote:
> nit: Can you take these out of namespace ash:: while you're here?

Done.

https://codereview.chromium.org/2084533008/diff/20001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2084533008/diff/20001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:82: // TODO(msw): Remove this when DisplayManager has been
moved.
On 2016/06/22 21:27:24, James Cook wrote:
> maybe cite the bug here?

Done.

[msw, 2016-06-22 22:16:19]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 22:17:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084533008/40001

[James Cook, 2016-06-22 22:20:36]

I agree ui::DisplayMode and ash::DisplayMode should be eventually combined, and
also that it's out of scope for this CL.

That will be an annoying piece of cleanup to do. :-(

[commit-bot: I haz the power, 2016-06-22 22:21:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 22:21:57]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-06-22 22:29:16]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 22:29:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084533008/60001

[msw, 2016-06-22 22:30:41]

Description was changed from

==========
mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
TBR=reveman@chromium.org,yusukes@chromium.org,sky@chromium.org
==========

[msw, 2016-06-22 22:31:49]

TBRing OWNERS for mechanical changes:
sky: chrome/*
yusukes: components/arc/*
reveman: components/exo/*

[commit-bot: I haz the power, 2016-06-22 23:30:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 23:30:52]

Dry run: This issue passed the CQ dry run.

[msw, 2016-06-22 23:50:12]

The CQ bit was checked by msw@chromium.org

[msw, 2016-06-22 23:50:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2084533008/#ps60001
(title: "Sync and rebase.")

[commit-bot: I haz the power, 2016-06-22 23:50:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084533008/60001

[commit-bot: I haz the power, 2016-06-22 23:59:15]

Description was changed from

==========
mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
TBR=reveman@chromium.org,yusukes@chromium.org,sky@chromium.org
==========

to

==========
mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
TBR=reveman@chromium.org,yusukes@chromium.org,sky@chromium.org
==========

[commit-bot: I haz the power, 2016-06-22 23:59:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-23 00:01:08]

Description was changed from

==========
mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
TBR=reveman@chromium.org,yusukes@chromium.org,sky@chromium.org
==========

to

==========
mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
TBR=reveman@chromium.org,yusukes@chromium.org,sky@chromium.org

Committed: https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72
Cr-Commit-Position: refs/heads/master@{#401470}
==========

[commit-bot: I haz the power, 2016-06-23 00:01:10]

Patchset 4 (id:??) landed as
https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72
Cr-Commit-Position: refs/heads/master@{#401470}