YUV scale filter columns improved filtering accuracy

YUV scale filter columns improved filtering accuracy

upscale a YUV image.  observe change in hue.. green especially.
disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C
observe hue.. green especially, is better.

was ScaleFrom1280x720_Bilinear (1620 ms)
now ScaleFrom1280x720_Bilinear (1907 ms)

BUG=libyuv:605
TEST=try bots
R=harryjin@google.com, wangcheng@google.com

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/cc88adc6209f3aa9c25adc6be02743fa2e9e9c80

[fbarchard1, 2016-06-22 01:41:38]

Description was changed from

==========
tighten up test

BUG=libyuv:604
==========

to

==========
YUV scale filter columns improved filtering accuracy

BUG=libyuv:605
==========

[fbarchard1, 2016-06-22 17:34:46]

fbarchard@google.com changed reviewers:
+ harryjin@google.com

[fbarchard1, 2016-06-22 17:34:47]

improved quality YUV scaling with more accurate column code.

[harryjin, 2016-06-22 17:49:57]

lgtm

[fbarchard1, 2016-06-22 19:06:44]

Description was changed from

==========
YUV scale filter columns improved filtering accuracy

BUG=libyuv:605
==========

to

==========
YUV scale filter columns improved filtering accuracy

upscale a YUV image.  observe change in hue.. green especially.
disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C
observe hue.. green especially, is better.

was ScaleFrom1280x720_Bilinear (1620 ms)
now ScaleFrom1280x720_Bilinear (1907 ms)

BUG=libyuv:605
TEST=
==========

[fbarchard1, 2016-06-22 19:28:28]

clangcl on windows has a build error?

ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
"..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
/showIncludes /FC @obj\source\libyuv.scale_win.obj.rsp /c
..\..\source\scale_win.cc /Foobj\source\libyuv.scale_win.obj
/Fdobj\libyuv.cc.pdb 
..\..\source\scale_win.cc(877,3):  error: invalid operand for instruction
  __asm {
  ^
<inline asm>(35,2):  note: instantiated into assembly here
        psubb xmm0, byte ptr kFsub80
        ^
..\..\source\scale_win.cc(877,3):  error: invalid operand for instruction
  __asm {
  ^
<inline asm>(41,2):  note: instantiated into assembly here
        paddw xmm1, word ptr kFadd40
        ^
..\..\source\scale_win.cc(877,3):  error: invalid operand for instruction
  __asm {
  ^
<inline asm>(56,2):  note: instantiated into assembly here
        psubb xmm0, byte ptr kFsub80
        ^
..\..\source\scale_win.cc(877,3):  error: invalid operand for instruction
  __asm {
  ^
<inline asm>(60,2):  note: instantiated into assembly here
        paddw xmm2, word ptr kFadd40
        ^
4 errors generated.

[fbarchard1, 2016-06-22 23:29:31]

reported clang-cl issue https://llvm.org/bugs/show_bug.cgi?id=28266

[fbarchard1, 2016-06-23 18:48:05]

Description was changed from

==========
YUV scale filter columns improved filtering accuracy

upscale a YUV image.  observe change in hue.. green especially.
disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C
observe hue.. green especially, is better.

was ScaleFrom1280x720_Bilinear (1620 ms)
now ScaleFrom1280x720_Bilinear (1907 ms)

BUG=libyuv:605
TEST=
==========

to

==========
YUV scale filter columns improved filtering accuracy

upscale a YUV image.  observe change in hue.. green especially.
disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C
observe hue.. green especially, is better.

was ScaleFrom1280x720_Bilinear (1620 ms)
now ScaleFrom1280x720_Bilinear (1907 ms)

BUG=libyuv:605
TEST=try bots
==========

[wangcheng, 2016-06-23 22:56:59]

wangcheng@google.com changed reviewers:
+ wangcheng@google.com

[wangcheng, 2016-06-23 22:56:59]

lgtm

[fbarchard1, 2016-06-24 03:16:58]

Description was changed from

==========
YUV scale filter columns improved filtering accuracy

upscale a YUV image.  observe change in hue.. green especially.
disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C
observe hue.. green especially, is better.

was ScaleFrom1280x720_Bilinear (1620 ms)
now ScaleFrom1280x720_Bilinear (1907 ms)

BUG=libyuv:605
TEST=try bots
==========

to

==========
YUV scale filter columns improved filtering accuracy

upscale a YUV image.  observe change in hue.. green especially.
disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C
observe hue.. green especially, is better.

was ScaleFrom1280x720_Bilinear (1620 ms)
now ScaleFrom1280x720_Bilinear (1907 ms)

BUG=libyuv:605
TEST=try bots
R=harryjin@google.com, wangcheng@google.com

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/cc88adc6209f3aa9c25adc6be02...
==========

[fbarchard1, 2016-06-24 03:17:00]

Committed patchset #11 (id:200001) manually as
cc88adc6209f3aa9c25adc6be02743fa2e9e9c80 (presubmit successful).