src/core/SkTextBlobRunIterator.h - Issue 2084533004: SkTextBlob: Begin implementing Extended TextBlob API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/core/SkTextBlobRunIterator.h

Issue 2084533004: SkTextBlob: Begin implementing Extended TextBlob API (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: 2016-06-24 (Friday) 17:22:15 EDT Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2015 Google Inc.	2 * Copyright 2015 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7 #ifndef SkTextBlobRunIterator_DEFINED	7 #ifndef SkTextBlobRunIterator_DEFINED

8 #define SkTextBlobRunIterator_DEFINED	8 #define SkTextBlobRunIterator_DEFINED

9	9

10 #include "SkTextBlob.h"	10 #include "SkTextBlob.h"

(...skipping 10 matching lines...) Expand all Loading...
21	21

22 bool done() const;	22 bool done() const;

23 void next();	23 void next();

24	24

25 uint32_t glyphCount() const;	25 uint32_t glyphCount() const;

26 const uint16_t* glyphs() const;	26 const uint16_t* glyphs() const;

27 const SkScalar* pos() const;	27 const SkScalar* pos() const;

28 const SkPoint& offset() const;	28 const SkPoint& offset() const;

29 void applyFontToPaint(SkPaint*) const;	29 void applyFontToPaint(SkPaint*) const;

30 SkTextBlob::GlyphPositioning positioning() const;	30 SkTextBlob::GlyphPositioning positioning() const;

	31 bool isExtended() const;
	f(malita) 2016/06/27 20:21:56 This is just an alias for textSize() > 0, right? This is just an alias for textSize() > 0, right? Clients can always check themselves, I don't think we need this helper. hal.canary 2016/06/28 15:39:13 Done. Show quoted text On 2016/06/27 20:21:56, f(malita) wrote: > This is just an alias for textSize() > 0, right? > > Clients can always check themselves, I don't think we need this helper. Done.
	32 uint32_t* clusterBuffer() const;
	f(malita) 2016/06/27 20:21:56 nit: clusters() for consistency? nit: clusters() for consistency? hal.canary 2016/06/28 15:39:13 Done. Show quoted text On 2016/06/27 20:21:56, f(malita) wrote: > nit: clusters() for consistency? Done.
	33 uint32_t textSize() const;

	34 char* textBuffer() const;
	f(malita) 2016/06/27 20:21:56 nit: text() for consistency? nit: text() for consistency? hal.canary 2016/06/28 15:39:13 Done. Show quoted text On 2016/06/27 20:21:56, f(malita) wrote: > nit: text() for consistency? Done.
	35

31 bool isLCD() const;	36 bool isLCD() const;

32	37

33 private:	38 private:

34 const SkTextBlob::RunRecord* fCurrentRun;	39 const SkTextBlob::RunRecord* fCurrentRun;

35 int fRemainingRuns;	40 int fRemainingRuns;

36	41

37 SkDEBUGCODE(uint8_t* fStorageTop;)	42 SkDEBUGCODE(uint8_t* fStorageTop;)

38 };	43 };

39	44

40 #endif // SkTextBlobRunIterator_DEFINED	45 #endif // SkTextBlobRunIterator_DEFINED

OLD	NEW

« src/core/SkTextBlob.cpp ('K') | « src/core/SkTextBlob.cpp ('k') | tests/ExtendedTextBlob.cpp » ('j') | tests/ExtendedTextBlob.cpp » ('J')