Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per further review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index 6ef6916e80fee04257adb5e197b34376dba8bacc..599127952ccb64070c1fd198dcbd0c5f4ee02b4f 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -54,14 +54,30 @@ void ContentPasswordManagerDriver::AccountCreationFormsFound(
forms));
}
-void ContentPasswordManagerDriver::AcceptPasswordAutofillSuggestion(
+void ContentPasswordManagerDriver::FillSuggestion(
const base::string16& username,
const base::string16& password) {
content::RenderViewHost* host = web_contents()->GetRenderViewHost();
host->Send(
- new AutofillMsg_AcceptPasswordAutofillSuggestion(host->GetRoutingID(),
- username,
- password));
+ new AutofillMsg_FillPasswordSuggestion(host->GetRoutingID(),
+ username,
+ password));
+}
+
+void ContentPasswordManagerDriver::PreviewSuggestion(
+ const base::string16& username,
+ const base::string16& password) {
+ content::RenderViewHost* host = web_contents()->GetRenderViewHost();
+ host->Send(
+ new AutofillMsg_PreviewPasswordSuggestion(host->GetRoutingID(),
+ username,
+ password));
+}
+
+void ContentPasswordManagerDriver::ClearPreviewedForm() {
+ content::RenderViewHost* host = web_contents()->GetRenderViewHost();
+ host->Send(
+ new AutofillMsg_ClearPreviewedForm(host->GetRoutingID()));
}
bool ContentPasswordManagerDriver::DidLastPageLoadEncounterSSLErrors() {

Powered by Google App Engine
This is Rietveld 408576698