components/autofill/content/renderer/autofill_agent.h - Issue 208453002: Add "previewing on hover" support for password field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per review comments on SelectionRange. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/common/autofill_messages.h ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | components/autofill/content/renderer/password_autofill_agent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/autofill_agent.h

diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h

index a5de5ad9aa599992b946c6f197231560a29bfaee..df3137046686a15bf97cb45c76d8d8fad7172a08 100644

--- a/components/autofill/content/renderer/autofill_agent.h

+++ b/components/autofill/content/renderer/autofill_agent.h

@@ -102,8 +102,10 @@ class AutofillAgent : public content::RenderViewObserver,

void OnFillFieldWithValue(const base::string16& value);

void OnPreviewFieldWithValue(const base::string16& value);

void OnAcceptDataListSuggestion(const base::string16& value);

- void OnAcceptPasswordAutofillSuggestion(const base::string16& username,

- const base::string16& password);

+ void OnFillPasswordSuggestion(const base::string16& username,

+ const base::string16& password);

+ void OnPreviewPasswordSuggestion(const base::string16& username,

+ const base::string16& password);

// Called when interactive autocomplete finishes. |message| is printed to

// the console if non-empty.