components/password_manager/core/browser/password_generation_manager_unittest.cc - Issue 208453002: Add "previewing on hover" support for password field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per Ilya's further comments after rebasing. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_autofill_manager.cc ('K') | « components/password_manager/core/browser/password_autofill_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_driver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc

index 2187c214d99f3539a71cbc29da053b61098ec40c..ade89a20c880b50d39461dafb23c2d5a9d2c823d 100644

--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc

@@ -60,10 +60,11 @@ class TestPasswordManagerDriver : public PasswordManagerDriver {

found_account_creation_forms_.insert(

found_account_creation_forms_.begin(), forms.begin(), forms.end());

}

- virtual void AcceptPasswordAutofillSuggestion(

- const base::string16& username,

- const base::string16& password) OVERRIDE {

- }

+ virtual void FillSuggestion(const base::string16& username,

+ const base::string16& password) OVERRIDE {}

+ virtual void PreviewSuggestion(const base::string16& username,

+ const base::string16& password) OVERRIDE {}

+ virtual void ClearPreviewedForm() OVERRIDE {}

const std::vector<autofill::FormData>& GetFoundAccountCreationForms() {

return found_account_creation_forms_;