components/password_manager/content/browser/content_password_manager_driver.h - Issue 208453002: Add "previewing on hover" support for password field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per Ilya's further comments after rebasing. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/password_manager/content/browser/content_password_manager_driver.cc » ('j') | components/password_manager/core/browser/password_autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.h

diff --git a/components/password_manager/content/browser/content_password_manager_driver.h b/components/password_manager/content/browser/content_password_manager_driver.h

index d055b407d2f8c60312846f74dce049a9fc112417..4fb2e9019b53c4e34b5f4a8fcda5272c7c4c2a9c 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.h

+++ b/components/password_manager/content/browser/content_password_manager_driver.h

@@ -42,9 +42,11 @@ class ContentPasswordManagerDriver : public PasswordManagerDriver,

OVERRIDE;

virtual void AccountCreationFormsFound(

const std::vector<autofill::FormData>& forms) OVERRIDE;

- virtual void AcceptPasswordAutofillSuggestion(

- const base::string16& username,

- const base::string16& password) OVERRIDE;

+ virtual void FillSuggestion(const base::string16& username,

+ const base::string16& password) OVERRIDE;

+ virtual void PreviewSuggestion(const base::string16& username,

+ const base::string16& password) OVERRIDE;

+ virtual void ClearPreviewedForm() OVERRIDE;

virtual PasswordGenerationManager* GetPasswordGenerationManager() OVERRIDE;

virtual PasswordManager* GetPasswordManager() OVERRIDE;