components/autofill/content/common/autofill_messages.h - Issue 208453002: Add "previewing on hover" support for password field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update code as per Ilya's further comments after rebasing. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/autofill_agent.h » ('j') | components/autofill/content/renderer/password_autofill_agent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 0fa84302fedee7c1cc7d7e4f5b3aeca4af514d47..9af06a4455e55d42bc753b7be63da4008e1688be 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -142,9 +142,15 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptDataListSuggestion,

IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,

base::string16 /* generated_password */)

-// Tells the renderer that the user accepted a password autofill suggestion,

-// and that renderer should set the username and password to the given values.

-IPC_MESSAGE_ROUTED2(AutofillMsg_AcceptPasswordAutofillSuggestion,

+// Tells the renderer to fill the username and password with with given

Ilya Sherman 2014/05/15 21:36:09 nit: You have an extra space between "the" and "us

ziran.sun 2014/05/16 09:18:13 Done.

+// values.

+IPC_MESSAGE_ROUTED2(AutofillMsg_FillPasswordSuggestion,

+ base::string16 /* username */,

+ base::string16 /* password */)

+// Tells the renderer to preview the username and password with the given

+// values.

+IPC_MESSAGE_ROUTED2(AutofillMsg_PreviewPasswordSuggestion,

base::string16 /* username */,

base::string16 /* password */)