Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: components/autofill/content/renderer/form_autofill_util.cc

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve rebased code. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/form_autofill_util.cc
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc
index 965f7f6695f207a83e232c23810bbaaa0875a75e..5ddf212f1ba26c36e0d20b264fd77369cee56d90 100644
--- a/components/autofill/content/renderer/form_autofill_util.cc
+++ b/components/autofill/content/renderer/form_autofill_util.cc
@@ -1045,14 +1045,14 @@ void PreviewForm(const FormData& form, const WebFormControlElement& element) {
}
bool ClearPreviewedFormWithElement(const WebFormControlElement& element,
- bool was_autofilled) {
+ bool was_autofilled,
+ bool was_password_autofilled) {
WebFormElement form_element = element.form();
if (form_element.isNull())
return false;
std::vector<WebFormControlElement> control_elements;
- ExtractAutofillableElements(form_element, REQUIRE_AUTOCOMPLETE,
- &control_elements);
+ ExtractAutofillableElements(form_element, REQUIRE_NONE, &control_elements);
for (size_t i = 0; i < control_elements.size(); ++i) {
// There might be unrelated elements in this form which have already been
// auto-filled. For example, the user might have already filled the address
@@ -1093,6 +1093,8 @@ bool ClearPreviewedFormWithElement(const WebFormControlElement& element,
// cursor.
int length = control_element.value().length();
control_element.setSelectionRange(length, length);
+ } else if (input_element->isPasswordField()) {
+ input_element->setAutofilled(was_password_autofilled);
} else {
control_element.setAutofilled(false);
}

Powered by Google App Engine
This is Rietveld 408576698