Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: components/autofill/core/browser/password_autofill_manager.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per Ilya's comment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/password_autofill_manager.h
diff --git a/components/autofill/core/browser/password_autofill_manager.h b/components/autofill/core/browser/password_autofill_manager.h
index ddde78eb0faa337f9a1ef49f98af8daca681e231..60c861a3b85b9fd58fc3b8dc169d5a7aa11bd527 100644
--- a/components/autofill/core/browser/password_autofill_manager.h
+++ b/components/autofill/core/browser/password_autofill_manager.h
@@ -26,10 +26,15 @@ class PasswordAutofillManager {
explicit PasswordAutofillManager(AutofillDriver* autofill_driver);
virtual ~PasswordAutofillManager();
+ // Previews the password associated with user name |username|. Returns true if
+ // the username and password fields were previewed, false otherwise.
+ bool DidSelectSuggestion(const FormFieldData& field,
+ const base::string16& username);
+
// Fills the password associated with user name |username|. Returns true if
// the username and password fields were filled, false otherwise.
- bool DidAcceptAutofillSuggestion(const FormFieldData& field,
- const base::string16& username);
+ bool DidAcceptSuggestion(const FormFieldData& field,
+ const base::string16& username);
// Invoked when a password mapping is added.
void AddPasswordFormMapping(

Powered by Google App Engine
This is Rietveld 408576698