Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: components/autofill/core/browser/password_autofill_manager.cc

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/password_autofill_manager.cc
diff --git a/components/autofill/core/browser/password_autofill_manager.cc b/components/autofill/core/browser/password_autofill_manager.cc
index 730c10e49d5d1b2282440dcf3dd406593cd3977b..d55a13a2bf969e585a51ac8a2dfa59b28e30355f 100644
--- a/components/autofill/core/browser/password_autofill_manager.cc
+++ b/components/autofill/core/browser/password_autofill_manager.cc
@@ -20,6 +20,21 @@ PasswordAutofillManager::PasswordAutofillManager(
PasswordAutofillManager::~PasswordAutofillManager() {
}
+bool PasswordAutofillManager::DidSelectAutofillSuggestion(
+ const FormFieldData& field,
+ const base::string16& username) {
+ PasswordFormFillData password;
+ if (!FindLoginInfo(field, &password))
+ return false;
+
+ if (WillFillUserNameAndPassword(username, password)) {
+ autofill_driver_->RendererShouldPreviewPassword(username);
Ilya Sherman 2014/03/21 22:35:19 Can we send both the username and the password dow
ziran.sun 2014/03/25 18:25:26 I might have a quick work on DidAcceptAutofillSugg
Ilya Sherman 2014/03/25 19:45:27 Sounds great -- thanks! I've filed http://crbug.c
+ return true;
+ }
+
+ return false;
+ }
+
bool PasswordAutofillManager::DidAcceptAutofillSuggestion(
const FormFieldData& field,
const base::string16& username) {

Powered by Google App Engine
This is Rietveld 408576698