Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: components/autofill/core/browser/autofill_external_delegate.cc

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc
index f435ceb8e23563face4edc083b1d815f12adcca7..3df7cd3b95d004bfb5710f4f7c99cf83d3889cdf 100644
--- a/components/autofill/core/browser/autofill_external_delegate.cc
+++ b/components/autofill/core/browser/autofill_external_delegate.cc
@@ -168,10 +168,14 @@ void AutofillExternalDelegate::DidSelectSuggestion(
ClearPreviewedForm();
// Only preview the data if it is a profile.
- if (identifier > 0)
+ if (identifier > 0) {
FillAutofillFormData(identifier, true);
- else if (identifier == POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY)
+ } else if (identifier == POPUP_ITEM_ID_PASSWORD_ENTRY) {
+ password_manager_.DidSelectAutofillSuggestion(
+ query_field_, value);
Ilya Sherman 2014/03/21 22:35:19 Can we have a DCHECK(success) here as there is in
+ } else if (identifier == POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY) {
driver_->RendererShouldPreviewFieldWithValue(value);
+ }
}
void AutofillExternalDelegate::DidAcceptSuggestion(const base::string16& value,

Powered by Google App Engine
This is Rietveld 408576698