components/autofill/content/common/autofill_messages.h - Issue 208453002: Add "previewing on hover" support for password field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/browser/content_autofill_driver.h ('K') | « components/autofill/content/browser/content_autofill_driver_unittest.cc ('k') | components/autofill/content/renderer/autofill_agent.h » ('j') | components/autofill/content/renderer/autofill_agent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 9b01b5d2a61aa6c6da003472065b0c4e092c4d6a..5135339acd49352056f7eed71287aa4e2bcb4aef 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -140,7 +140,11 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,

// Tells the renderer that the password field has accept the suggestion.

IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,

- base::string16 /* username value*/)

+ base::string16 /* username value */)

Ilya Sherman 2014/03/21 22:35:19 nit: "username value" -> "username" here and below

ziran.sun 2014/03/25 18:25:26 Done.

+// Preview the password for the selected username.

+IPC_MESSAGE_ROUTED1(AutofillMsg_PreviewPassword,

+ base::string16 /* username value */)

// Tells the renderer that this password form is not blacklisted. A form can

// be blacklisted if a user chooses "never save passwords for this site".