Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: components/password_manager/core/browser/password_manager_driver.h

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update code as per further review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/password_manager/core/browser/password_generation_manager_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 namespace autofill { 10 namespace autofill {
(...skipping 27 matching lines...) Expand all
38 // If this browsing session should not be persisted. 38 // If this browsing session should not be persisted.
39 virtual bool IsOffTheRecord() = 0; 39 virtual bool IsOffTheRecord() = 0;
40 40
41 // Informs the driver that |form| can be used for password generation. 41 // Informs the driver that |form| can be used for password generation.
42 virtual void AllowPasswordGenerationForForm(autofill::PasswordForm* form) = 0; 42 virtual void AllowPasswordGenerationForForm(autofill::PasswordForm* form) = 0;
43 43
44 // Notifies the driver that account creation |forms| were found. 44 // Notifies the driver that account creation |forms| were found.
45 virtual void AccountCreationFormsFound( 45 virtual void AccountCreationFormsFound(
46 const std::vector<autofill::FormData>& forms) = 0; 46 const std::vector<autofill::FormData>& forms) = 0;
47 47
48 // Tells the driver to accept the password autofill suggestion for |username| 48 // Tells the driver to fill the form with the |username| and |password|.
49 // and fill the password with |password|. 49 virtual void FillSuggestion(const base::string16& username,
50 virtual void AcceptPasswordAutofillSuggestion( 50 const base::string16& password) = 0;
51 const base::string16& username, 51
52 const base::string16& password) = 0; 52 // Tells the driver to preview filling form with the |username| and
53 // |password|.
54 virtual void PreviewSuggestion(const base::string16& username,
55 const base::string16& password) = 0;
56
57 // Tells the driver to clear previewed password and username fields.
58 virtual void ClearPreviewedForm() = 0;
53 59
54 // Returns the PasswordGenerationManager associated with this instance. 60 // Returns the PasswordGenerationManager associated with this instance.
55 virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0; 61 virtual PasswordGenerationManager* GetPasswordGenerationManager() = 0;
56 62
57 // Returns the PasswordManager associated with this instance. 63 // Returns the PasswordManager associated with this instance.
58 virtual PasswordManager* GetPasswordManager() = 0; 64 virtual PasswordManager* GetPasswordManager() = 0;
59 65
60 // Returns the PasswordAutofillManager associated with this instance. 66 // Returns the PasswordAutofillManager associated with this instance.
61 virtual PasswordAutofillManager* GetPasswordAutofillManager() = 0; 67 virtual PasswordAutofillManager* GetPasswordAutofillManager() = 0;
62 68
63 // Returns the AutofillManager associated with this instance. 69 // Returns the AutofillManager associated with this instance.
64 virtual autofill::AutofillManager* GetAutofillManager() = 0; 70 virtual autofill::AutofillManager* GetAutofillManager() = 0;
65 71
66 private: 72 private:
67 DISALLOW_COPY_AND_ASSIGN(PasswordManagerDriver); 73 DISALLOW_COPY_AND_ASSIGN(PasswordManagerDriver);
68 }; 74 };
69 75
70 } // namespace password_manager 76 } // namespace password_manager
71 77
72 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_ 78 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_DRIVER_H_
OLDNEW
« no previous file with comments | « components/password_manager/core/browser/password_generation_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698