Add "previewing on hover" support for password field.

components/autofill/content/renderer/password_autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 22 matching lines @@
   // WebViewClient editor related calls forwarded by the RenderView.
   // If they return true, it indicates the event was consumed and should not
   // be used for any other autofill activity.
   bool TextFieldDidEndEditing(const blink::WebInputElement& element);
   bool TextDidChangeInTextField(const blink::WebInputElement& element);
   bool TextFieldHandlingKeyDown(const blink::WebInputElement& element,
                                 const blink::WebKeyboardEvent& event);
 
   // Fills the username and password fields of this form with the given values.
   // Returns true if the fields were filled, false otherwise.
-  bool AcceptSuggestion(const blink::WebNode& node,
-                        const blink::WebString& username,
-                        const blink::WebString& password);
+  bool FillSuggestion(const blink::WebNode& node,
+                      const blink::WebString& username,
+                      const blink::WebString& password);

[Ilya Sherman, 2014/05/14 23:10:58]

nit: Please leave a blank line after this one.

[ziran.sun, 2014/05/15 12:36:37]

Done.

+  // Previews the username and password fields of this form with the given
+  // values. Returns true if the fields were previewed, false otherwise.
+  bool PreviewSuggestion(const blink::WebNode& node,
+                         const blink::WebString& username,
+                         const blink::WebString& password);
+  // A public version of ClearPreview(), only for use in tests.
+  bool ClearPreviewForTest(blink::WebInputElement* username,
+                           blink::WebInputElement* password);

[Ilya Sherman, 2014/05/14 23:10:58]

nit: Please move this to the very bottom of the "public" section, since it's not
really part of the public API that clients should be using.

[ziran.sun, 2014/05/15 12:36:37]

This function has been removed.

 
   // A no-op.  Password forms are not previewed, so they do not need to be
   // cleared when the selection changes.  However, this method returns
   // true when |node| is fillable by password Autofill.

[Ilya Sherman, 2014/05/14 23:10:58]

Please update this documentation.

[ziran.sun, 2014/05/15 12:36:37]

Done.

   bool DidClearAutofillSelection(const blink::WebNode& node);
   // Shows an Autofill popup with username suggestions for |element|.
   // Returns true if any suggestions were shown, false otherwise.
   bool ShowSuggestions(const blink::WebInputElement& element);
 
   // Called when new form controls are inserted.
   void OnDynamicFormsSeen(blink::WebFrame* frame);
 
   // Called when the user first interacts with the page after a load. This is a
   // signal to make autofilled values of password input elements accessible to
@@ skipping 86 matching lines @@
 
   // Attempts to fill |username_element| and |password_element| with the
   // |fill_data|.  Will use the data corresponding to the preferred username,
   // unless the |username_element| already has a value set.  In that case,
   // attempts to fill the password matching the already filled username, if
   // such a password exists.
   void FillFormOnPasswordRecieved(const PasswordFormFillData& fill_data,
                                   blink::WebInputElement username_element,
                                   blink::WebInputElement password_element);
 
-  bool FillUserNameAndPassword(
-      blink::WebInputElement* username_element,
-      blink::WebInputElement* password_element,
-      const PasswordFormFillData& fill_data,
-      bool exact_username_match,
-      bool set_selection);
+  bool FillUserNameAndPassword(blink::WebInputElement* username_element,
+                               blink::WebInputElement* password_element,
+                               const PasswordFormFillData& fill_data,
+                               bool exact_username_match,
+                               bool set_selection);
 
   // Fills |login_input| and |password| with the most relevant suggestion from
   // |fill_data| and shows a popup with other suggestions.
   void PerformInlineAutocomplete(
       const blink::WebInputElement& username,
       const blink::WebInputElement& password,
       const PasswordFormFillData& fill_data);
 
   // Invoked when the passed frame is closing.  Gives us a chance to clear any
   // reference we may have to elements in that frame.
   void FrameClosing(const blink::WebFrame* frame);
 
   // Finds login information for a |node| that was previously filled.
   bool FindLoginInfo(const blink::WebNode& node,
                      blink::WebInputElement* found_input,
                      PasswordInfo* found_password);
 
+  // Clears previewed username and password.

[Ilya Sherman, 2014/05/14 23:10:58]

nit: "Clears the preview for the username and password fields, restoring both to
their previous filled state."

[ziran.sun, 2014/05/15 12:36:37]

Done.

+  bool ClearPreview(blink::WebInputElement* username,
+                    blink::WebInputElement* password);
+
   // If |provisionally_saved_forms_| contains a form for |current_frame| or its
   // children, return such frame.
   blink::WebFrame* CurrentOrChildFrameWithSavedForms(
       const blink::WebFrame* current_frame);
 
   // The logins we have filled so far with their associated info.
   LoginToPasswordInfoMap login_to_password_info_;
 
   // Used for UMA stats.
   OtherPossibleUsernamesUsage usernames_usage_;
 
   // Pointer to the WebView. Used to access page scale factor.
   blink::WebView* web_view_;
 
   // Set if the user might be submitting a password form on the current page,
   // but the submit may still fail (i.e. doesn't pass JavaScript validation).
   FrameToPasswordFormMap provisionally_saved_forms_;
 
   PasswordValueGatekeeper gatekeeper_;
 
   // True indicates that user debug information should be logged.
   bool logging_state_active_;
 
+  // True indicates that the username field was autofilled, false otherwise.
+  bool was_username_autofilled_;
+  // True indicates that the password field was autofilled, false otherwise.
+  bool was_password_autofilled_;
+
   base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_