Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 208453002: Add "previewing on hover" support for password field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve rebased code. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/prefs/pref_registry_simple.h" 7 #include "base/prefs/pref_registry_simple.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/prefs/testing_pref_service.h" 9 #include "base/prefs/testing_pref_service.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 OVERRIDE {} 57 OVERRIDE {}
58 virtual void AccountCreationFormsFound( 58 virtual void AccountCreationFormsFound(
59 const std::vector<autofill::FormData>& forms) OVERRIDE { 59 const std::vector<autofill::FormData>& forms) OVERRIDE {
60 found_account_creation_forms_.insert( 60 found_account_creation_forms_.insert(
61 found_account_creation_forms_.begin(), forms.begin(), forms.end()); 61 found_account_creation_forms_.begin(), forms.begin(), forms.end());
62 } 62 }
63 virtual void AcceptPasswordAutofillSuggestion( 63 virtual void AcceptPasswordAutofillSuggestion(
64 const base::string16& username, 64 const base::string16& username,
65 const base::string16& password) OVERRIDE { 65 const base::string16& password) OVERRIDE {
66 } 66 }
67 67
Ilya Sherman 2014/05/13 00:44:05 nit: No need for a blank line here, because these
ziran.sun 2014/05/14 15:35:12 Done.
68 virtual void PreviewPasswordAutofillSuggestion(
69 const base::string16& username,
70 const base::string16& password) OVERRIDE {
71 }
72
Ilya Sherman 2014/05/13 00:44:05 nit: Same applies here as well.
ziran.sun 2014/05/14 15:35:12 Done.
73 virtual void ClearPasswordPreviewedForm() OVERRIDE {}
74
68 const std::vector<autofill::FormData>& GetFoundAccountCreationForms() { 75 const std::vector<autofill::FormData>& GetFoundAccountCreationForms() {
69 return found_account_creation_forms_; 76 return found_account_creation_forms_;
70 } 77 }
71 void set_is_off_the_record(bool is_off_the_record) { 78 void set_is_off_the_record(bool is_off_the_record) {
72 is_off_the_record_ = is_off_the_record; 79 is_off_the_record_ = is_off_the_record;
73 } 80 }
74 81
75 private: 82 private:
76 PasswordManager password_manager_; 83 PasswordManager password_manager_;
77 PasswordGenerationManager password_generation_manager_; 84 PasswordGenerationManager password_generation_manager_;
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 // be disabled. 232 // be disabled.
226 GetTestDriver()->set_is_off_the_record(true); 233 GetTestDriver()->set_is_off_the_record(true);
227 PrefService* prefs = client_->GetPrefs(); 234 PrefService* prefs = client_->GetPrefs();
228 prefs->SetBoolean(prefs::kPasswordManagerEnabled, true); 235 prefs->SetBoolean(prefs::kPasswordManagerEnabled, true);
229 client_->set_is_password_sync_enabled(true); 236 client_->set_is_password_sync_enabled(true);
230 237
231 EXPECT_FALSE(IsGenerationEnabled()); 238 EXPECT_FALSE(IsGenerationEnabled());
232 } 239 }
233 240
234 } // namespace password_manager 241 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698