Add "previewing on hover" support for password field.

components/password_manager/core/browser/password_autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/common/autofill_data_validation.h"
 #include "components/password_manager/core/browser/password_autofill_manager.h"
 #include "components/password_manager/core/browser/password_manager_client.h"
@@ skipping 22 matching lines @@
   base::string16 password;
   if (FindLoginInfo(field, &fill_data) &&
       GetPasswordForUsername(username, fill_data, &password)) {
     PasswordManagerDriver* driver = password_manager_client_->GetDriver();
     driver->AcceptPasswordAutofillSuggestion(username, password);
     return true;
   }
   return false;
 }
 
+bool PasswordAutofillManager::SelectSuggestion(
+    const autofill::FormFieldData& field,
+    const base::string16& username) {
+  autofill::PasswordFormFillData fill_data;
+  base::string16 password;
+  if (FindLoginInfo(field, &fill_data) &&
+      GetPasswordForUsername(username, fill_data, &password)) {
+    PasswordManagerDriver* driver = password_manager_client_->GetDriver();
+    driver->PreviewPasswordAutofillSuggestion(username, password);
+    return true;
+  }
+  return false;
+}
+
 void PasswordAutofillManager::OnAddPasswordFormMapping(
     const autofill::FormFieldData& field,
     const autofill::PasswordFormFillData& fill_data) {
   if (!autofill::IsValidFormFieldData(field) ||
       !autofill::IsValidPasswordFormFillData(fill_data))
     return;
 
   login_to_password_info_[field] = fill_data;
 }
 
@@ skipping 30 matching lines @@
 void PasswordAutofillManager::Reset() {
   login_to_password_info_.clear();
 }
 
 bool PasswordAutofillManager::AcceptSuggestionForTest(
     const autofill::FormFieldData& field,
     const base::string16& username) {
   return AcceptSuggestion(field, username);
 }
 
+bool PasswordAutofillManager::SelectSuggestionForTest(
+    const autofill::FormFieldData& field,
+    const base::string16& username) {
+  return SelectSuggestion(field, username);
+}
+
 void PasswordAutofillManager::OnPopupShown() {
 }
 
 void PasswordAutofillManager::OnPopupHidden() {
 }
 
 void PasswordAutofillManager::DidSelectSuggestion(const base::string16& value,
                                                   int identifier) {
-  // This is called to preview an autofill suggestion, but we don't currently
-  // do that for password forms (crbug.com/63421). If it is ever implemented,
-  // ClearPreviewedForm() must also be implemented().
+  ClearPreviewedForm();
+  if (!SelectSuggestion(form_field_, value))
+    NOTREACHED();

[Ilya Sherman, 2014/05/13 00:44:05]

nit: Please write these two lines as

bool success = SelectSuggestion(form_field_, value);
DCHECK(success);

[ziran.sun, 2014/05/14 15:35:12]

What about NOTREACHED() uses in other places of this file? Does it make sense to
replace them with DCHECK as well?

[Ilya Sherman, 2014/05/14 23:10:58]

Yes, let's do that :)

[ziran.sun, 2014/05/15 12:36:37]

Done.

 }
 
 void PasswordAutofillManager::DidAcceptSuggestion(const base::string16& value,
                                                   int identifier) {
   if (!AcceptSuggestion(form_field_, value))
     NOTREACHED();
   autofill_manager_delegate_->HideAutofillPopup();
 }
 
 void PasswordAutofillManager::RemoveSuggestion(const base::string16& value,
                                                int identifier) {
   NOTREACHED();
 }
 
 void PasswordAutofillManager::ClearPreviewedForm() {
-  // There is currently no preview for password autofill (crbug.com/63421).
-  // This function needs an implemention if preview is ever implemented.
+  PasswordManagerDriver* driver = password_manager_client_->GetDriver();
+  driver->ClearPasswordPreviewedForm();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillManager, private:
 
 bool PasswordAutofillManager::GetPasswordForUsername(
     const base::string16& current_username,
     const autofill::PasswordFormFillData& fill_data,
     base::string16* password) {
   // TODO(dubroy): When password access requires some kind of authentication
@@ skipping 37 matching lines @@
     autofill::PasswordFormFillData* found_password) {
   LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(field);
   if (iter == login_to_password_info_.end())
     return false;
 
   *found_password = iter->second;
   return true;
 }
 
 }  //  namespace password_manager