Add "previewing on hover" support for password field.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
@@ skipping 144 matching lines @@
                         OnFieldTypePredictionsAvailable)
     IPC_MESSAGE_HANDLER(AutofillMsg_ClearForm, OnClearForm)
     IPC_MESSAGE_HANDLER(AutofillMsg_ClearPreviewedForm, OnClearPreviewedForm)
     IPC_MESSAGE_HANDLER(AutofillMsg_FillFieldWithValue, OnFillFieldWithValue)
     IPC_MESSAGE_HANDLER(AutofillMsg_PreviewFieldWithValue,
                         OnPreviewFieldWithValue)
     IPC_MESSAGE_HANDLER(AutofillMsg_AcceptDataListSuggestion,
                         OnAcceptDataListSuggestion)
     IPC_MESSAGE_HANDLER(AutofillMsg_AcceptPasswordAutofillSuggestion,
                         OnAcceptPasswordAutofillSuggestion)
+    IPC_MESSAGE_HANDLER(AutofillMsg_PreviewPasswordAutofillSuggestion,
+                        OnPreviewPasswordAutofillSuggestion)
     IPC_MESSAGE_HANDLER(AutofillMsg_RequestAutocompleteResult,
                         OnRequestAutocompleteResult)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void AutofillAgent::DidFinishDocumentLoad(WebLocalFrame* frame) {
   // Record timestamp on document load. This is used to record overhead of
   // Autofill feature.
@@ skipping 304 matching lines @@
 
 void AutofillAgent::OnClearForm() {
   form_cache_.ClearFormWithElement(element_);
 }
 
 void AutofillAgent::OnClearPreviewedForm() {
   if (!element_.isNull()) {
     if (password_autofill_agent_->DidClearAutofillSelection(element_))
       return;
 
-    ClearPreviewedFormWithElement(element_, was_query_node_autofilled_);
+    ClearPreviewedFormWithElement(
+        element_,
+        was_query_node_autofilled_,
+        password_autofill_agent_->WasPasswordAutofilled());

[Ilya Sherman, 2014/05/13 00:44:05]

This call site should not need to change as a result of the password changes. 
Those changes should be internal to the PasswordAutofillAgent class.

[ziran.sun, 2014/05/14 15:35:12]

Done.

   } else {
     // TODO(isherman): There seem to be rare cases where this code *is*
     // reachable: see [ http://crbug.com/96321#c6 ].  Ideally we would
     // understand those cases and fix the code to avoid them.  However, so far I
     // have been unable to reproduce such a case locally.  If you hit this
     // NOTREACHED(), please file a bug against me.
     NOTREACHED();
   }
 }
 
@@ skipping 16 matching lines @@
 void AutofillAgent::OnAcceptPasswordAutofillSuggestion(
     const base::string16& username,
     const base::string16& password) {
   bool handled = password_autofill_agent_->AcceptSuggestion(
       element_,
       username,
       password);
   DCHECK(handled);
 }
 
+void AutofillAgent::OnPreviewPasswordAutofillSuggestion(
+    const base::string16& username,
+    const base::string16& password) {
+  was_query_node_autofilled_ = element_.isAutofilled();

[Ilya Sherman, 2014/05/13 00:44:05]

This should be tracked internally to the PasswordAutofillAgent class.  So,
you'll need two new instance variables within that class:
was_username_autofilled_ and was_password_autofilled_.

[ziran.sun, 2014/05/14 15:35:12]

Done.

+  bool handled = password_autofill_agent_->SelectSuggestion(
+      element_,
+      username,
+      password);
+  DCHECK(handled);
+}
+
 void AutofillAgent::OnRequestAutocompleteResult(
     WebFormElement::AutocompleteResult result,
     const base::string16& message,
     const FormData& form_data) {
   if (in_flight_request_form_.isNull())
     return;
 
   if (result == WebFormElement::AutocompleteResultSuccess) {
     FillFormIncludingNonFocusableElements(form_data, in_flight_request_form_);
     if (!in_flight_request_form_.checkValidity())
@@ skipping 164 matching lines @@
     // Only monitors dynamic forms created in the top frame. Dynamic forms
     // inserted in iframes are not captured yet.
     if (frame && !frame->parent()) {
       password_autofill_agent_->OnDynamicFormsSeen(frame);
       return;
     }
   }
 }
 
 }  // namespace autofill