Add "previewing on hover" support for password field.

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autocomplete_history_manager.h"
 #include "components/autofill/core/browser/autofill_driver.h"
 #include "components/autofill/core/browser/autofill_manager.h"
@@ skipping 150 matching lines @@
   NOTREACHED();
   return true;
 }
 
 void AutofillExternalDelegate::DidSelectSuggestion(
     const base::string16& value,
     int identifier) {
   ClearPreviewedForm();
 
   // Only preview the data if it is a profile.
-  if (identifier > 0)
+  if (identifier > 0) {
     FillAutofillFormData(identifier, true);
-  else if (identifier == POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY)
+  } else if (identifier == POPUP_ITEM_ID_PASSWORD_ENTRY) {
+    bool success = password_manager_.DidSelectSuggestion(query_field_, value);
+    DCHECK(success);
+  } else if (identifier == POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY) {
     driver_->RendererShouldPreviewFieldWithValue(value);
+  }
 }
 
 void AutofillExternalDelegate::DidAcceptSuggestion(const base::string16& value,
                                                    int identifier) {
   if (identifier == POPUP_ITEM_ID_AUTOFILL_OPTIONS) {
     // User selected 'Autofill Options'.
     manager_->ShowAutofillSettings();
   } else if (identifier == POPUP_ITEM_ID_CLEAR_FORM) {
     // User selected 'Clear form'.
     driver_->RendererShouldClearFilledForm();
   } else if (identifier == POPUP_ITEM_ID_PASSWORD_ENTRY) {
-    bool success = password_manager_.DidAcceptAutofillSuggestion(
+    bool success = password_manager_.DidAcceptSuggestion(
         query_field_, value);

[Ilya Sherman, 2014/03/25 19:45:27]

nit: Looks like this now fits on the previous line.

     DCHECK(success);
   } else if (identifier == POPUP_ITEM_ID_DATALIST_ENTRY) {
     driver_->RendererShouldAcceptDataListSuggestion(value);
   } else if (identifier == POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY) {
     // User selected an Autocomplete, so we fill directly.
     driver_->RendererShouldFillFieldWithValue(value);
   } else {
     FillAutofillFormData(identifier, false);
   }
 
@@ skipping 146 matching lines @@
   // Set the values that all datalist elements share.
   icons->insert(icons->begin(),
                 data_list_values_.size(),
                 base::string16());
   unique_ids->insert(unique_ids->begin(),
                      data_list_values_.size(),
                      POPUP_ITEM_ID_DATALIST_ENTRY);
 }
 
 }  // namespace autofill