Add "previewing on hover" support for password field.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
@@ skipping 139 matching lines @@
                         OnFieldTypePredictionsAvailable)
     IPC_MESSAGE_HANDLER(AutofillMsg_ClearForm, OnClearForm)
     IPC_MESSAGE_HANDLER(AutofillMsg_ClearPreviewedForm, OnClearPreviewedForm)
     IPC_MESSAGE_HANDLER(AutofillMsg_FillFieldWithValue, OnFillFieldWithValue)
     IPC_MESSAGE_HANDLER(AutofillMsg_PreviewFieldWithValue,
                         OnPreviewFieldWithValue)
     IPC_MESSAGE_HANDLER(AutofillMsg_AcceptDataListSuggestion,
                         OnAcceptDataListSuggestion)
     IPC_MESSAGE_HANDLER(AutofillMsg_AcceptPasswordAutofillSuggestion,
                         OnAcceptPasswordAutofillSuggestion)
+    IPC_MESSAGE_HANDLER(AutofillMsg_PreviewPassword, OnPreviewPassword)
     IPC_MESSAGE_HANDLER(AutofillMsg_RequestAutocompleteResult,
                         OnRequestAutocompleteResult)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void AutofillAgent::DidFinishDocumentLoad(WebFrame* frame) {
   // Record timestamp on document load. This is used to record overhead of
   // Autofill feature.
@@ skipping 259 matching lines @@
   PreviewForm(form, element_);
   Send(new AutofillHostMsg_DidPreviewAutofillFormData(routing_id()));
 }
 
 void AutofillAgent::OnClearForm() {
   form_cache_.ClearFormWithElement(element_);
 }
 
 void AutofillAgent::OnClearPreviewedForm() {
   if (!element_.isNull()) {
-    if (password_autofill_agent_->DidClearAutofillSelection(element_))
+    if (password_autofill_agent_->DidClearAutofillSelection(element_) &&
+        !password_autofill_agent_->IsPasswordPreviewed())
       return;
 
-    ClearPreviewedFormWithElement(element_, was_query_node_autofilled_);
+    if(password_autofill_agent_->IsPasswordPreviewed()) {
+      ClearPreviewedFormWithElement(
+          element_,
+          REQUIRE_NONE,
+          was_query_node_autofilled_,
+          password_autofill_agent_->WasPasswordAutofilled());

[Ilya Sherman, 2014/03/25 19:45:27]

Please move all of the password-related logic for clearing the previewed form to
be part of password_autofill_agent_->DidClearAutofillSelection().  There should
be minimal changes to the AutofillAgent class for this change.

+    } else {
+      ClearPreviewedFormWithElement(element_,
+                                    REQUIRE_AUTOCOMPLETE,
+                                    was_query_node_autofilled_,
+                                    false);
+    }
   } else {
     // TODO(isherman): There seem to be rare cases where this code *is*
     // reachable: see [ http://crbug.com/96321#c6 ].  Ideally we would
     // understand those cases and fix the code to avoid them.  However, so far I
     // have been unable to reproduce such a case locally.  If you hit this
     // NOTREACHED(), please file a bug against me.
     NOTREACHED();
   }
 }
 
 void AutofillAgent::OnFillFieldWithValue(const base::string16& value) {
   FillFieldWithValue(value, &element_);
 }
 
 void AutofillAgent::OnPreviewFieldWithValue(const base::string16& value) {
   PreviewFieldWithValue(value, &element_);
 }
 
 void AutofillAgent::OnAcceptDataListSuggestion(const base::string16& value) {
   AcceptDataListSuggestion(value);
 }
 
 void AutofillAgent::OnAcceptPasswordAutofillSuggestion(
     const base::string16& username) {
   // We need to make sure this is handled here because the browser process
   // skipped it handling because it believed it would be handled here. If it
   // isn't handled here then the browser logic needs to be updated.
-  bool handled = password_autofill_agent_->DidAcceptAutofillSuggestion(
+  bool handled = password_autofill_agent_->DidAcceptSuggestion(
       element_,
       username);
   DCHECK(handled);
+}
+
+void AutofillAgent::OnPreviewPassword(const base::string16& username) {
+  was_query_node_autofilled_ = element_.isAutofilled();
+  bool handled = password_autofill_agent_->DidSelectSuggestion(
+      element_,
+      username);
+  DCHECK(handled);
 }
 
 void AutofillAgent::OnRequestAutocompleteResult(
     WebFormElement::AutocompleteResult result,
     const FormData& form_data) {
   if (in_flight_request_form_.isNull())
     return;
 
   if (result == WebFormElement::AutocompleteResultSuccess) {
     FillFormIncludingNonFocusableElements(form_data, in_flight_request_form_);
@@ skipping 137 matching lines @@
     // Only monitors dynamic forms created in the top frame. Dynamic forms
     // inserted in iframes are not captured yet.
     if (frame && !frame->parent()) {
       password_autofill_agent_->OnDynamicFormsSeen(frame);
       return;
     }
   }
 }
 
 }  // namespace autofill