Add "previewing on hover" support for password field.

chrome/renderer/autofill/form_autofill_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
@@ skipping 2819 matching lines @@
   expected.value = ASCIIToUTF16("?");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields2[2]);
 
   // Verify that the cursor position has been updated.
   EXPECT_EQ(0, firstname.selectionStart());
   EXPECT_EQ(0, firstname.selectionEnd());
 }
 
+TEST_F(FormAutofillTest, ClearPreviewedPasswordWithPasswordAutofilled) {
+  LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
+           "  <INPUT type=\"text\" id=\"username\"/>"
+           "  <INPUT type=\"password\" id=\"password\" value=\"s\"/>"
+           "  <INPUT type=\"submit\" value=\"Send\"/>"
+           "</FORM>");
+
+  WebFrame* web_frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
+
+  // Set the auto-filled attribute.
+  WebInputElement username =
+      web_frame->document().getElementById("username").to<WebInputElement>();
+  username.setAutofilled(true);
+  WebInputElement password =
+      web_frame->document().getElementById("password").to<WebInputElement>();
+  password.setAutofilled(true);
+
+  username.setSuggestedValue(ASCIIToUTF16("Wyatt"));
+  password.setSuggestedValue(ASCIIToUTF16("secret"));
+
+  EXPECT_TRUE(ClearPreviewedFormWithElement(username, REQUIRE_NONE, false,
+                                            true));
+
+  EXPECT_TRUE(username.value().isEmpty());
+  EXPECT_TRUE(username.suggestedValue().isEmpty());
+  EXPECT_FALSE(username.isAutofilled());
+
+  EXPECT_EQ(ASCIIToUTF16("s"), password.value());
+  EXPECT_TRUE(password.suggestedValue().isEmpty());
+  EXPECT_TRUE(password.isAutofilled());
+}
+
+TEST_F(FormAutofillTest, ClearPreviewedPasswordWithUserNameAutofilled) {
+  LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
+           "  <INPUT type=\"text\" id=\"username\" value=\"W\"/>"
+           "  <INPUT type=\"password\" id=\"password\"/>"
+           "  <INPUT type=\"submit\" value=\"Send\"/>"
+           "</FORM>");
+
+  WebFrame* web_frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
+
+  WebInputElement username =
+      web_frame->document().getElementById("username").to<WebInputElement>();
+  username.setAutofilled(true);
+  WebInputElement password =
+      web_frame->document().getElementById("password").to<WebInputElement>();
+  password.setAutofilled(true);
+
+  username.setSuggestedValue(ASCIIToUTF16("Wyatt"));
+  password.setSuggestedValue(ASCIIToUTF16("secret"));
+
+  EXPECT_TRUE(ClearPreviewedFormWithElement(username, REQUIRE_NONE, true,
+                                            false));
+
+  EXPECT_EQ(ASCIIToUTF16("W"), username.value());
+  EXPECT_TRUE(username.suggestedValue().isEmpty());
+  EXPECT_TRUE(username.isAutofilled());
+
+  EXPECT_TRUE(password.value().isEmpty());
+  EXPECT_TRUE(password.suggestedValue().isEmpty());
+  EXPECT_FALSE(password.isAutofilled());
+}
+
+TEST_F(FormAutofillTest,
+       ClearPreviewedPasswordWithAutofilledUserNameAndPassword) {
+  LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
+           "  <INPUT type=\"text\" id=\"username\" value=\"W\"/>"
+           "  <INPUT type=\"password\" id=\"password\" value=\"s\"/>"
+           "  <INPUT type=\"submit\" value=\"Send\"/>"
+           "</FORM>");
+
+  WebFrame* web_frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
+
+  WebInputElement username =
+      web_frame->document().getElementById("username").to<WebInputElement>();
+  username.setAutofilled(true);
+  WebInputElement password =
+      web_frame->document().getElementById("password").to<WebInputElement>();
+  password.setAutofilled(true);
+
+  username.setSuggestedValue(ASCIIToUTF16("Wyatt"));
+  password.setSuggestedValue(ASCIIToUTF16("secret"));
+
+  EXPECT_TRUE(ClearPreviewedFormWithElement(username, REQUIRE_NONE, true,
+                                            true));
+
+  EXPECT_EQ(ASCIIToUTF16("W"), username.value());
+  EXPECT_TRUE(username.suggestedValue().isEmpty());
+  EXPECT_TRUE(username.isAutofilled());
+
+  EXPECT_EQ(ASCIIToUTF16("s"), password.value());
+  EXPECT_TRUE(password.suggestedValue().isEmpty());
+  EXPECT_TRUE(password.isAutofilled());
+}
+
+TEST_F(FormAutofillTest,
+       ClearPreviewedPasswordWithNotAutofilledUserNameAndPassword) {
+  LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
+           "  <INPUT type=\"text\" id=\"username\"/>"
+           "  <INPUT type=\"password\" id=\"password\"/>"
+           "  <INPUT type=\"submit\" value=\"Send\"/>"
+           "</FORM>");
+
+  WebFrame* web_frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
+
+  // Set the auto-filled attribute.
+  WebInputElement username =
+      web_frame->document().getElementById("username").to<WebInputElement>();
+  username.setAutofilled(true);
+  WebInputElement password =
+      web_frame->document().getElementById("password").to<WebInputElement>();
+  password.setAutofilled(true);
+
+  username.setSuggestedValue(ASCIIToUTF16("Wyatt"));
+  password.setSuggestedValue(ASCIIToUTF16("secret"));
+
+  // Clear the previewed fields.
+  EXPECT_TRUE(ClearPreviewedFormWithElement(username, REQUIRE_NONE, false,
+                                            false));
+
+  EXPECT_TRUE(username.value().isEmpty());
+  EXPECT_TRUE(username.suggestedValue().isEmpty());
+  EXPECT_FALSE(username.isAutofilled());
+
+  EXPECT_TRUE(password.value().isEmpty());
+  EXPECT_TRUE(password.suggestedValue().isEmpty());
+  EXPECT_FALSE(password.isAutofilled());
+}
+
+TEST_F(FormAutofillTest,
+       ClearPreviewedPasswordWithEmptyUserNameSuggestion) {
+  LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
+           "  <INPUT type=\"text\" id=\"username\"/>"
+           "  <INPUT type=\"password\" id=\"password\"/>"
+           "  <INPUT type=\"submit\" value=\"Send\"/>"
+           "</FORM>");
+
+  WebFrame* web_frame = GetMainFrame();
+  ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
+
+  WebInputElement username =
+      web_frame->document().getElementById("username").to<WebInputElement>();
+  username.setAutofilled(true);
+  WebInputElement password =
+      web_frame->document().getElementById("password").to<WebInputElement>();
+  password.setAutofilled(true);
+
+  username.setSuggestedValue(base::string16());
+
+  EXPECT_TRUE(ClearPreviewedFormWithElement(username, REQUIRE_NONE, false,
+                                            false));
+  EXPECT_TRUE(username.value().isEmpty());
+  EXPECT_TRUE(username.suggestedValue().isEmpty());
+  EXPECT_TRUE(username.isAutofilled());
+
+  EXPECT_TRUE(password.value().isEmpty());
+  EXPECT_TRUE(password.suggestedValue().isEmpty());
+  EXPECT_TRUE(password.isAutofilled());
+}
+
 TEST_F(FormAutofillTest, ClearPreviewedFormWithElement) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
            "  <INPUT type=\"text\" id=\"firstname\" value=\"Wyatt\"/>"
            "  <INPUT type=\"text\" id=\"lastname\"/>"
            "  <INPUT type=\"text\" id=\"email\"/>"
            "  <INPUT type=\"email\" id=\"email2\"/>"
            "  <INPUT type=\"tel\" id=\"phone\"/>"
            "  <INPUT type=\"submit\" value=\"Send\"/>"
            "</FORM>");
 
@@ skipping 22 matching lines @@
       web_frame->document().getElementById("phone").to<WebInputElement>();
   phone.setAutofilled(true);
 
   // Set the suggested values on two of the elements.
   lastname.setSuggestedValue(ASCIIToUTF16("Earp"));
   email.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   email2.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   phone.setSuggestedValue(ASCIIToUTF16("650-777-9999"));
 
   // Clear the previewed fields.
-  EXPECT_TRUE(ClearPreviewedFormWithElement(lastname, false));
+  EXPECT_TRUE(ClearPreviewedFormWithElement(lastname, REQUIRE_AUTOCOMPLETE,
+                                            false, false));
 
   // Fields with empty suggestions suggestions are not modified.
   EXPECT_EQ(ASCIIToUTF16("Wyatt"), firstname.value());
   EXPECT_TRUE(firstname.suggestedValue().isEmpty());
   EXPECT_TRUE(firstname.isAutofilled());
 
   // Verify the previewed fields are cleared.
   EXPECT_TRUE(lastname.value().isEmpty());
   EXPECT_TRUE(lastname.suggestedValue().isEmpty());
   EXPECT_FALSE(lastname.isAutofilled());
@@ skipping 49 matching lines @@
 
 
   // Set the suggested values on all of the elements.
   firstname.setSuggestedValue(ASCIIToUTF16("Wyatt"));
   lastname.setSuggestedValue(ASCIIToUTF16("Earp"));
   email.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   email2.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   phone.setSuggestedValue(ASCIIToUTF16("650-777-9999"));
 
   // Clear the previewed fields.
-  EXPECT_TRUE(ClearPreviewedFormWithElement(firstname, false));
+  EXPECT_TRUE(ClearPreviewedFormWithElement(firstname, REQUIRE_AUTOCOMPLETE,
+                                            false, false));
 
   // Fields with non-empty values are restored.
   EXPECT_EQ(ASCIIToUTF16("W"), firstname.value());
   EXPECT_TRUE(firstname.suggestedValue().isEmpty());
   EXPECT_FALSE(firstname.isAutofilled());
   EXPECT_EQ(1, firstname.selectionStart());
   EXPECT_EQ(1, firstname.selectionEnd());
 
   // Verify the previewed fields are cleared.
   EXPECT_TRUE(lastname.value().isEmpty());
@@ skipping 46 matching lines @@
   phone.setAutofilled(true);
 
   // Set the suggested values on all of the elements.
   firstname.setSuggestedValue(ASCIIToUTF16("Wyatt"));
   lastname.setSuggestedValue(ASCIIToUTF16("Earp"));
   email.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   email2.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
   phone.setSuggestedValue(ASCIIToUTF16("650-777-9999"));
 
   // Clear the previewed fields.
-  EXPECT_TRUE(ClearPreviewedFormWithElement(firstname, true));
+  EXPECT_TRUE(ClearPreviewedFormWithElement(firstname, REQUIRE_AUTOCOMPLETE,
+                                            true, false));
 
   // Fields with non-empty values are restored.
   EXPECT_EQ(ASCIIToUTF16("W"), firstname.value());
   EXPECT_TRUE(firstname.suggestedValue().isEmpty());
   EXPECT_TRUE(firstname.isAutofilled());
   EXPECT_EQ(1, firstname.selectionStart());
   EXPECT_EQ(1, firstname.selectionEnd());
 
   // Verify the previewed fields are cleared.
   EXPECT_TRUE(lastname.value().isEmpty());
@@ skipping 184 matching lines @@
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[1]);
 
   expected.name = ASCIIToUTF16("country");
   expected.value = ASCIIToUTF16("AL");
   expected.form_control_type = "select-one";
   expected.max_length = 0;
   EXPECT_FORM_FIELD_DATA_EQUALS(expected, fields[2]);
 }
 
 }  // namespace autofill